Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: Do not crash on invalid codes

2019-04-21 Thread Michael Niedermayer
On Sun, Apr 21, 2019 at 11:31:10AM +0200, Paul B Mahol wrote: > On 4/21/19, Michael Niedermayer wrote: > > I do not know if such vlc trees are allowed in agm, I have no specification > > So i do not know if these should be treated as error, or not. > > But the code does contain a check for idx < 0

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: Do not crash on invalid codes

2019-04-21 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer wrote: > I do not know if such vlc trees are allowed in agm, I have no specification > So i do not know if these should be treated as error, or not. > But the code does contain a check for idx < 0 already ... > > untested due to lack of valid samples using this code

[FFmpeg-devel] [PATCH 1/3] avcodec/agm: Do not crash on invalid codes

2019-04-21 Thread Michael Niedermayer
I do not know if such vlc trees are allowed in agm, I have no specification So i do not know if these should be treated as error, or not. But the code does contain a check for idx < 0 already ... untested due to lack of valid samples using this codepath Fixes: Stack-buffer-overflow in get_tree_co