Re: [FFmpeg-devel] [PATCH 1/2 v3] add libaribb24 ARIB STD-B24 caption decoder

2019-02-10 Thread Jan Ekström
On Mon, Feb 11, 2019 at 1:01 AM Michael Niedermayer wrote: > > On Sun, Feb 03, 2019 at 09:38:40PM +0200, Jan Ekström wrote: > > +#define RGB_TO_BGR(c) ((c & 0xff) << 16 | (c & 0xff00) | ((c >> 16) & > > 0xff)) > > c should be protected by a () > First of all, thank you for the technical review.

Re: [FFmpeg-devel] [PATCH 1/2 v3] add libaribb24 ARIB STD-B24 caption decoder

2019-02-10 Thread Michael Niedermayer
On Sun, Feb 03, 2019 at 09:38:40PM +0200, Jan Ekström wrote: > * Outputs ASS lines with basic coloring and font scaling for each > given region. > * Sets the default style to the resolution of the subtitle plane > (for example, 960x540 / 36pt font for profile A). > * Has options to: > * Disab

Re: [FFmpeg-devel] [PATCH 1/2 v3] add libaribb24 ARIB STD-B24 caption decoder

2019-02-09 Thread Jan Ekström
Noticed some minor issues while doing my final check-up of the patch set, which I fixed locally. Checked that the configure checks still failed if you tried to enable libaribb24 without version3, and that if the version of the library is old enough, it would fail without gpl being enabled. On Sun,

[FFmpeg-devel] [PATCH 1/2 v3] add libaribb24 ARIB STD-B24 caption decoder

2019-02-03 Thread Jan Ekström
* Outputs ASS lines with basic coloring and font scaling for each given region. * Sets the default style to the resolution of the subtitle plane (for example, 960x540 / 36pt font for profile A). * Has options to: * Disable ruby text (which is coded as regions which have half-height text i