Re: [FFmpeg-devel] [PATCH 1/2 v2] mov: Remove ancient heuristic hack

2016-08-25 Thread Derek Buitenhuis
On 8/25/2016 5:49 PM, Derek Buitenhuis wrote: > However, removing the part about the sample being missing in > the commit message would be wrong, because it is, in fact, not > linked in the commit message. I must step out now, so please push whenever some consensus is reached. No point in bikeshed

Re: [FFmpeg-devel] [PATCH 1/2 v2] mov: Remove ancient heuristic hack

2016-08-25 Thread Derek Buitenhuis
On 8/25/2016 5:18 PM, Michael Niedermayer wrote: > ok if i push with the changes requested in: > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2016-August/198303.html > ? (seems another reply with forgotten CC) You can change 'hack' to 'incorrect workaround' if you wish. However, removing the p

Re: [FFmpeg-devel] [PATCH 1/2 v2] mov: Remove ancient heuristic hack

2016-08-25 Thread Michael Niedermayer
On Thu, Aug 25, 2016 at 04:58:14PM +0100, Derek Buitenhuis wrote: > This breaks files with legitimate single-entry edit lists, > and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b, > has no link to any known sample in its commit message. > > Signed-off-by: Derek Buitenhuis > ---

[FFmpeg-devel] [PATCH 1/2 v2] mov: Remove ancient heuristic hack

2016-08-25 Thread Derek Buitenhuis
This breaks files with legitimate single-entry edit lists, and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b, has no link to any known sample in its commit message. Signed-off-by: Derek Buitenhuis --- libavformat/isom.h | 1 - libavformat/mov.c | 8 +--- 2 files changed,