Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

2020-08-07 Thread Michael Niedermayer
On Fri, Aug 07, 2020 at 10:35:58PM +0200, Michael Niedermayer wrote: > On Thu, Aug 06, 2020 at 10:08:33PM +0300, Martin Storsjö wrote: > > On Mon, 3 Aug 2020, Martin Storsjö wrote: > > > > > On Mon, 3 Aug 2020, Michael Niedermayer wrote: > > > > > > > is this removing the only test which tests th

Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

2020-08-07 Thread James Almer
On 8/7/2020 5:35 PM, Michael Niedermayer wrote: > On Thu, Aug 06, 2020 at 10:08:33PM +0300, Martin Storsjö wrote: >> On Mon, 3 Aug 2020, Martin Storsjö wrote: >> >>> On Mon, 3 Aug 2020, Michael Niedermayer wrote: >>> is this removing the only test which tests the "-re" flag ? if so that w

Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

2020-08-07 Thread Michael Niedermayer
On Thu, Aug 06, 2020 at 10:08:33PM +0300, Martin Storsjö wrote: > On Mon, 3 Aug 2020, Martin Storsjö wrote: > > > On Mon, 3 Aug 2020, Michael Niedermayer wrote: > > > > > is this removing the only test which tests the "-re" flag ? > > > if so that would reduce test coverage > > > > Well, tehcnic

Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

2020-08-06 Thread Martin Storsjö
On Mon, 3 Aug 2020, Martin Storsjö wrote: On Mon, 3 Aug 2020, Michael Niedermayer wrote: is this removing the only test which tests the "-re" flag ? if so that would reduce test coverage Well, tehcnically yes, but this test doesn't actually test whether the "-re" flag does what it's suppose

Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

2020-08-03 Thread Martin Storsjö
On Mon, 3 Aug 2020, Michael Niedermayer wrote: On Sun, Aug 02, 2020 at 11:38:51PM +0300, Martin Storsjö wrote: This parameter artificially throttled the generation of the test sample to take 5 seconds. --- tests/fate/hlsenc.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

2020-08-03 Thread Michael Niedermayer
On Sun, Aug 02, 2020 at 11:38:51PM +0300, Martin Storsjö wrote: > This parameter artificially throttled the generation of the test sample > to take 5 seconds. > --- > tests/fate/hlsenc.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/fate/hlsenc.mak b/tests/fate/

Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

2020-08-02 Thread Steven Liu
Martin Storsjö 于2020年8月3日周一 上午4:39写道: > > This parameter artificially throttled the generation of the test sample > to take 5 seconds. > --- > tests/fate/hlsenc.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak > index dce1f

[FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

2020-08-02 Thread Martin Storsjö
This parameter artificially throttled the generation of the test sample to take 5 seconds. --- tests/fate/hlsenc.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak index dce1f377c7..3c767fd5d9 100644 --- a/tests/fate/hlsenc.mak +++