Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

2020-07-30 Thread Mark Thompson
On 30/07/2020 03:53, James Almer wrote: > The name could also be simply libsvtav1, same as the library (and the > configure option), since unlike libvpx and (in theory) libaom, no other > codec will be supported by it. HEVC is in a different library. That makes more sense. I'll use libsvtav1 eve

Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

2020-07-30 Thread Nicolas George
James Almer (12020-07-30): > This encoder was pushed yesterday night, which is why this change is > being suggested. It's not going to break anyone's use cases. Yes, I realized that afterwards and forgot to amend. But options with underscores are still the preferred form in the project. Regards,

Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

2020-07-30 Thread James Almer
On 7/30/2020 5:05 AM, Nicolas George wrote: > Mark Thompson (12020-07-29): >> Matching libaom-av1. > > As for options, most of FFmpeg uses underscores. It would be better to > use them too here. > > Also, you cannot rename options, you have to create aliases and > deprecate the original. Otherwis

Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

2020-07-30 Thread Nicolas George
Mark Thompson (12020-07-29): > Matching libaom-av1. As for options, most of FFmpeg uses underscores. It would be better to use them too here. Also, you cannot rename options, you have to create aliases and deprecate the original. Otherwise you break user cases. Regards, -- Nicolas George s

Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

2020-07-29 Thread James Almer
On 7/29/2020 7:50 PM, Mark Thompson wrote: > Matching libaom-av1. > --- > libavcodec/libsvt_av1.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/libsvt_av1.c b/libavcodec/libsvt_av1.c > index c7ae5f9691..3229551d2b 100644 > --- a/libavcodec/libsvt_a

[FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

2020-07-29 Thread Mark Thompson
Matching libaom-av1. --- libavcodec/libsvt_av1.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/libsvt_av1.c b/libavcodec/libsvt_av1.c index c7ae5f9691..3229551d2b 100644 --- a/libavcodec/libsvt_av1.c +++ b/libavcodec/libsvt_av1.c @@ -483,7 +483,7 @@ stat