Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-29 Thread Gautam Ramakrishnan
On Mon, Jun 29, 2020 at 6:28 PM Nicolas George wrote: > > Gautam Ramakrishnan (12020-06-27): > > I used 9 digits because I was using a fixed size string to store the number > > and then used strol. Now as I removed the usage of strol, it wasnt > > necessary. > > Do you thing using a loop of fixed

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-29 Thread Nicolas George
Gautam Ramakrishnan (12020-06-27): > I used 9 digits because I was using a fixed size string to store the number > and then used strol. Now as I removed the usage of strol, it wasnt necessary. > Do you thing using a loop of fixed iterations is a good idea? Is it better if > I use the for loop agai

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-27 Thread Gautam Ramakrishnan
On Sat, Jun 27, 2020 at 7:58 PM Nicolas George wrote: > > Michael Niedermayer (12020-06-27): > > this could overflow > > The original code had a test to limit the size of numbers to 9 digits, > guaranteeing no overflow. I wonder where it went. > I used 9 digits because I was using a fixed size str

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-27 Thread Gautam Ramakrishnan
On Sat, Jun 27, 2020 at 7:55 PM Michael Niedermayer wrote: > > On Sat, Jun 27, 2020 at 12:35:17PM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > This patch adds a pgx decoder. > > --- > > Changelog | 1 + > > doc/general.texi| 2 + > > libavcod

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-27 Thread Nicolas George
Michael Niedermayer (12020-06-27): > this could overflow The original code had a test to limit the size of numbers to 9 digits, guaranteeing no overflow. I wonder where it went. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-27 Thread Michael Niedermayer
On Sat, Jun 27, 2020 at 12:35:17PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds a pgx decoder. > --- > Changelog | 1 + > doc/general.texi| 2 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/code

[FFmpeg-devel] [PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-27 Thread gautamramk
From: Gautam Ramakrishnan This patch adds a pgx decoder. --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h | 1 + libavcodec/pgxdec.c | 184 ++