Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/libx264: do not define X264_API_IMPORTS

2018-09-03 Thread Hendrik Leppkes
On Mon, Sep 3, 2018 at 7:27 PM wrote: > > From: Anonymous Maarten > > These defines should be passed by pkg-config. Are they? Because if not, you should get that fixed upstream first before these commits are acceptable and cause regressions. - Hendrik ___

[FFmpeg-devel] [PATCH 1/2] libavcodec/libx264: do not define X264_API_IMPORTS

2018-09-03 Thread anonymous . maarten
From: Anonymous Maarten These defines should be passed by pkg-config. --- libavcodec/libx264.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 54e6703d73..b6f4c102c4 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -29,10 +2