Re: [FFmpeg-devel] [PATCH 1/2] lavf/url: add ff_url_decompose().

2020-08-04 Thread Nicolas George
Marton Balint (12020-08-04): > So you are returning NULL pointers here and success at the same time. This > does not look like a good idea, e.g. checking fields later on involves > arithmetic on NULL pointers, no? I don't really see it useful that we handle > NULL url here, we are better off with a

Re: [FFmpeg-devel] [PATCH 1/2] lavf/url: add ff_url_decompose().

2020-08-03 Thread Marton Balint
On Thu, 30 Jul 2020, Nicolas George wrote: Signed-off-by: Nicolas George --- libavformat/tests/url.c | 34 +++ libavformat/url.c | 74 + libavformat/url.h | 41 +++ tests/ref/fate/url | 45 ++

[FFmpeg-devel] [PATCH 1/2] lavf/url: add ff_url_decompose().

2020-07-30 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/tests/url.c | 34 +++ libavformat/url.c | 74 + libavformat/url.h | 41 +++ tests/ref/fate/url | 45 + 4 files changed, 194 insertions