Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: fix cookie parsing.

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 08:14:24PM +0200, Nicolas George wrote: > Le decadi 30 thermidor, an CCXXII, Michael Niedermayer a écrit : > > michaelni: oh, rly? well I know the code.. > > michaelni: I can look, weblink to patches? > > michaelni: oh, those, both ok > > If it means what I believe it me

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: fix cookie parsing.

2014-08-17 Thread Nicolas George
Le decadi 30 thermidor, an CCXXII, Michael Niedermayer a écrit : > michaelni: oh, rly? well I know the code.. > michaelni: I can look, weblink to patches? > michaelni: oh, those, both ok If it means what I believe it means, then: Thanks, pushed to my tree for merge. Regards, -- Nicolas Geo

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: fix cookie parsing.

2014-08-17 Thread Michael Niedermayer
On Sun, Aug 17, 2014 at 02:26:29PM +0200, Nicolas George wrote: > The current code would use any unknown attribute-value pair > as the cookie value. > RFC 6265 states that the first key-value pair is the actual > cookie, and the attribute-value pairs only start after. > > With the current code: >

[FFmpeg-devel] [PATCH 1/2] lavf/http: fix cookie parsing.

2014-08-17 Thread Nicolas George
The current code would use any unknown attribute-value pair as the cookie value. RFC 6265 states that the first key-value pair is the actual cookie, and the attribute-value pairs only start after. With the current code: Set-Cookie: test=good_value; path=/; dummy=42 gives this: Cookie: dummy=42 ins