Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 6:51 PM, Nicolas George wrote: > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> In ffserver the User-Agent is used to decide how to deal with a >> client. (WMP being a special case.) > > Ok, but that is special case for a specific application. > >> That soun

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Nicolas George
Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > In ffserver the User-Agent is used to decide how to deal with a > client. (WMP being a special case.) Ok, but that is special case for a specific application. > That sounds pretty optimistic. Maybe it is trivial for you, but from > my

[FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
Introduce the ability to set reply body and reply text and read the url-query, http-version and host parameter. Signed-off-by: Stephan Holljes --- libavformat/http.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) Does not export User-Agent, unlike the pr

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 5:32 PM, Nicolas George wrote: > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> Should the same be done for the Host-parameter sent by the client too? > > It can be discussed. > > On one hand, the Host field has a special meaning for the protocol, unlike > U

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Nicolas George
Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > Should the same be done for the Host-parameter sent by the client too? It can be discussed. On one hand, the Host field has a special meaning for the protocol, unlike User-Agent that is only used for logging, so it makes sense to give

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 5:15 PM, Nicolas George wrote: > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> Added to all while(!av_isspace(p)) loops in the server code. > > You may want to send this part in a stand-alone patch, since it is actually > a bug in the current code. > >> Thi

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Nicolas George
Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > Added to all while(!av_isspace(p)) loops in the server code. You may want to send this part in a stand-alone patch, since it is actually a bug in the current code. > This is more or less temporal, since the user-agent field is/will be

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 11:02 AM, Nicolas George wrote: > Thanks for the patch. A few remarks, specific to the stand-alone-commit > version or that I had not yet spotted. > > > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> Signed-off-by: Stephan Holljes >> --- >> libavformat/htt

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Nicolas George
Thanks for the patch. A few remarks, specific to the stand-alone-commit version or that I had not yet spotted. Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > Signed-off-by: Stephan Holljes > --- > libavformat/http.c | 40 ++-- > 1 file changed,

[FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-19 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- libavformat/http.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index a136918..bfe6801 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -64,12 +64