On date Sunday 2024-01-21 20:18:28 +0100, Stefano Sabatini wrote:
> On date Sunday 2024-01-21 18:39:19 +0100, Anton Khirnov wrote:
> > Quoting Stefano Sabatini (2024-01-21 11:30:27)
> [...]
> > Also, can the second case even trigger? Seems like the block above
> > ensures n_ast is never larger than
On date Sunday 2024-01-21 18:39:19 +0100, Anton Khirnov wrote:
> Quoting Stefano Sabatini (2024-01-21 11:30:27)
[...]
> Also, can the second case even trigger? Seems like the block above
> ensures n_ast is never larger than 2.
Yes, this seems a miss from commit
eafa8e859297813dcf0e6b43e85720be
Quoting Stefano Sabatini (2024-01-21 11:30:27)
> > > -if (((c->n_ast > 1) && (c->sys->n_difchan < 2)) ||
> > > -((c->n_ast > 2) && (c->sys->n_difchan < 4))) {
> > > -/* only 2 stereo pairs allowed in 50Mbps mode */
> > > -goto bail_out;
> > > +if ((c->n_ast > 1) && (
On date Sunday 2024-01-21 07:36:48 +0100, Anton Khirnov wrote:
> Quoting Stefano Sabatini (2024-01-20 16:24:07)
> > if ((c->sys->time_base.den != 25 && c->sys->time_base.den != 50) ||
> > c->sys->time_base.num != 1) {
> > -if (c->ast[0] && c->ast[0]->codecpar->sample_rate != 48000)
>
Quoting Stefano Sabatini (2024-01-20 16:24:07)
> if ((c->sys->time_base.den != 25 && c->sys->time_base.den != 50) ||
> c->sys->time_base.num != 1) {
> -if (c->ast[0] && c->ast[0]->codecpar->sample_rate != 48000)
> -goto bail_out;
> -if (c->ast[1] && c->ast[1]->code
Provide useful information about the failure in the error message, do not let
the user
guess.
---
libavformat/dvenc.c | 119 +++-
1 file changed, 85 insertions(+), 34 deletions(-)
diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c
index 29d2dc47ac..9a8
