Re: [FFmpeg-devel] [PATCH 1/2] ffplay: use AVSubtitleRect.data instead of .pict.data

2015-10-23 Thread wm4
On Fri, 23 Oct 2015 21:33:49 +0200 Hendrik Leppkes wrote: > On Fri, Oct 23, 2015 at 8:44 PM, Marton Balint wrote: > > Current code segfaults since the deprecation of AVSubtitleRect.pict because > > it > > frees/reallocs AVSubtitleRect.pict.data by itself. > > > > Patch looks fine, however I'

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: use AVSubtitleRect.data instead of .pict.data

2015-10-23 Thread Hendrik Leppkes
On Fri, Oct 23, 2015 at 8:44 PM, Marton Balint wrote: > Current code segfaults since the deprecation of AVSubtitleRect.pict because it > frees/reallocs AVSubtitleRect.pict.data by itself. > Patch looks fine, however I'm curious about this - does ffplay free data that was allocated by avcodec, and

[FFmpeg-devel] [PATCH 1/2] ffplay: use AVSubtitleRect.data instead of .pict.data

2015-10-23 Thread Marton Balint
Current code segfaults since the deprecation of AVSubtitleRect.pict because it frees/reallocs AVSubtitleRect.pict.data by itself. Signed-off-by: Marton Balint --- ffplay.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/ffplay.c b/ffplay.c ind