Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-04-04 Thread Ramiro Polla
On Sun, Mar 30, 2025 at 7:02 AM Gyan Doshi wrote: > On 2025-03-29 11:52 pm, Martin Storsjö wrote: > > On Sat, 29 Mar 2025, Gyan Doshi wrote: > > > >>> Did you not try to use GNU make's flie function? > >> > >> I just benched this and it ranges from 1m28.093s to 1m29.971s (5% > >> faster) for the l

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-30 Thread Ramiro Polla
On Sun, Mar 30, 2025 at 8:53 AM Gyan Doshi wrote: > On 2025-03-30 11:57 am, Andreas Rheinhardt wrote: > > Gyan Doshi: > >> On 2025-03-29 11:52 pm, Martin Storsjö wrote: > >>> On Sat, 29 Mar 2025, Gyan Doshi wrote: > >>> > > Did you not try to use GNU make's flie function? > I just benched

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-29 Thread Gyan Doshi
On 2025-03-30 11:57 am, Andreas Rheinhardt wrote: Gyan Doshi: On 2025-03-29 11:52 pm, Martin Storsjö wrote: On Sat, 29 Mar 2025, Gyan Doshi wrote: Did you not try to use GNU make's flie function? I just benched this and it ranges from 1m28.093s to 1m29.971s (5% faster) for the lavc target

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-29 Thread Andreas Rheinhardt
Gyan Doshi: > > > On 2025-03-29 11:52 pm, Martin Storsjö wrote: >> On Sat, 29 Mar 2025, Gyan Doshi wrote: >> Did you not try to use GNU make's flie function? >>> >>> I just benched this and it ranges from 1m28.093s to 1m29.971s (5% >>> faster) for the lavc targets. >>> However, this was adde

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-29 Thread Gyan Doshi
On 2025-03-29 11:52 pm, Martin Storsjö wrote: On Sat, 29 Mar 2025, Gyan Doshi wrote: Did you not try to use GNU make's flie function? I just benched this and it ranges from 1m28.093s to 1m29.971s (5% faster) for the lavc targets. However, this was added in make 4.0. Are we supporting olde

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-29 Thread Christopher Snowhill
On Sat Mar 29, 2025 at 10:02 PM PDT, Gyan Doshi wrote: > > > On 2025-03-29 11:52 pm, Martin Storsjö wrote: >> On Sat, 29 Mar 2025, Gyan Doshi wrote: >> Did you not try to use GNU make's flie function? >>> >>> I just benched this and it ranges from 1m28.093s to 1m29.971s (5% >>> faster) for th

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-29 Thread Martin Storsjö
On Sat, 29 Mar 2025, Gyan Doshi wrote: Did you not try to use GNU make's flie function? I just benched this and it ranges from 1m28.093s to 1m29.971s (5% faster) for the lavc targets. However, this was added in make 4.0. Are we supporting older make? Yes, we generally do support older GNU

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-29 Thread Gyan Doshi
On 2025-03-29 05:51 pm, Ramiro Polla wrote: Hi Gyan, On Sat, Mar 29, 2025 at 6:11 AM Gyan Doshi wrote: On 2025-03-27 10:03 am, Gyan Doshi wrote: On 2025-03-26 11:37 pm, Andreas Rheinhardt wrote: Gyan Doshi: On 2025-03-25 05:11 pm, Ramiro Polla wrote: On Sat, Mar 22, 2025 at 5:33 AM Gyan

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-29 Thread Ramiro Polla
Hi Gyan, On Sat, Mar 29, 2025 at 6:11 AM Gyan Doshi wrote: > On 2025-03-27 10:03 am, Gyan Doshi wrote: > > On 2025-03-26 11:37 pm, Andreas Rheinhardt wrote: > >> Gyan Doshi: > >>> On 2025-03-25 05:11 pm, Ramiro Polla wrote: > On Sat, Mar 22, 2025 at 5:33 AM Gyan Doshi wrote: > > On 2025

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-28 Thread Gyan Doshi
On 2025-03-27 10:03 am, Gyan Doshi wrote: On 2025-03-26 11:37 pm, Andreas Rheinhardt wrote: Gyan Doshi: On 2025-03-25 05:11 pm, Ramiro Polla wrote: Hi, On Sat, Mar 22, 2025 at 5:33 AM Gyan Doshi wrote: On 2025-03-22 03:29 am, Martin Storsjö wrote: On Fri, 21 Mar 2025, Gyan Doshi wrote

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-26 Thread Gyan Doshi
On 2025-03-26 11:37 pm, Andreas Rheinhardt wrote: Gyan Doshi: On 2025-03-25 05:11 pm, Ramiro Polla wrote: Hi, On Sat, Mar 22, 2025 at 5:33 AM Gyan Doshi wrote: On 2025-03-22 03:29 am, Martin Storsjö wrote: On Fri, 21 Mar 2025, Gyan Doshi wrote: ffbuild/library.mak | 7 +-- 1 file cha

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-26 Thread Gyan Doshi
On 2025-03-25 05:11 pm, Ramiro Polla wrote: Hi, On Sat, Mar 22, 2025 at 5:33 AM Gyan Doshi wrote: On 2025-03-22 03:29 am, Martin Storsjö wrote: On Fri, 21 Mar 2025, Gyan Doshi wrote: ffbuild/library.mak | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ffbuild/libra

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-25 Thread Ramiro Polla
Hi, On Sat, Mar 22, 2025 at 5:33 AM Gyan Doshi wrote: > On 2025-03-22 03:29 am, Martin Storsjö wrote: > > On Fri, 21 Mar 2025, Gyan Doshi wrote: > >> ffbuild/library.mak | 7 +-- > >> 1 file changed, 5 insertions(+), 2 deletions(-) > >> > >> diff --git a/ffbuild/library.mak b/ffbuild/library.m

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-21 Thread Gyan Doshi
On 2025-03-22 03:29 am, Martin Storsjö wrote: On Fri, 21 Mar 2025, Gyan Doshi wrote: Avoids echo failing due to the same ARG_MAX limit that prompted response files to be used with the linker. I presume this is only a fix for a hypothetical issue, _if_ echo would be a native windows executa

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-21 Thread Martin Storsjö
On Fri, 21 Mar 2025, Gyan Doshi wrote: Avoids echo failing due to the same ARG_MAX limit that prompted response files to be used with the linker. I presume this is only a fix for a hypothetical issue, _if_ echo would be a native windows executable and not the msys2/cygwin one which bypasses

[FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-21 Thread Gyan Doshi
Avoids echo failing due to the same ARG_MAX limit that prompted response files to be used with the linker. --- ffbuild/library.mak | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ffbuild/library.mak b/ffbuild/library.mak index 7e1871b74c..15302852ec 100644 --- a/ffbuild/