Re: [FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Forward errors when reading packet

2020-02-19 Thread Michael Niedermayer
On Wed, Feb 19, 2020 at 08:16:03PM +1100, Peter Ross wrote: > On Tue, Feb 18, 2020 at 12:36:00PM +, Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > > wtvfile_read_packet did not abide by the requirements of an > > > AVIOContext's read_packet-function: If it did not read anything, > > > it

Re: [FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Forward errors when reading packet

2020-02-19 Thread Peter Ross
On Tue, Feb 18, 2020 at 12:36:00PM +, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > wtvfile_read_packet did not abide by the requirements of an > > AVIOContext's read_packet-function: If it did not read anything, > > it returned zero, which currently leads to a warning in read_packet_wrap

Re: [FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Forward errors when reading packet

2020-02-18 Thread Andreas Rheinhardt
Andreas Rheinhardt: > wtvfile_read_packet did not abide by the requirements of an > AVIOContext's read_packet-function: If it did not read anything, > it returned zero, which currently leads to a warning in read_packet_wrapper > in aviobuf.c. Said warning will be an av_assert2 as soon as > FF_API_O

[FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Forward errors when reading packet

2020-02-10 Thread Andreas Rheinhardt
wtvfile_read_packet did not abide by the requirements of an AVIOContext's read_packet-function: If it did not read anything, it returned zero, which currently leads to a warning in read_packet_wrapper in aviobuf.c. Said warning will be an av_assert2 as soon as FF_API_OLD_AVIO_EOF_0 is zero (probabl