Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Andreas Rheinhardt
Paul B Mahol: > On 2/15/20, Andreas Rheinhardt wrote: >> Marton Balint: >>> >>> >>> On Sat, 15 Feb 2020, Nicolas George wrote: >>> Marton Balint (12020-02-15): >> +if (s->nb_streams) >> for (i = s->nb_streams - 1; i >= 0; i--) > Maybe rewrite the loop instead? >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Paul B Mahol
On 2/15/20, Andreas Rheinhardt wrote: > Marton Balint: >> >> >> On Sat, 15 Feb 2020, Nicolas George wrote: >> >>> Marton Balint (12020-02-15): > +if (s->nb_streams) > for (i = s->nb_streams - 1; i >= 0; i--) Maybe rewrite the loop instead? for (i = s->nb_streams; i-

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Andreas Rheinhardt
Marton Balint: > > > On Sat, 15 Feb 2020, Nicolas George wrote: > >> Marton Balint (12020-02-15): +    if (s->nb_streams)     for (i = s->nb_streams - 1; i >= 0; i--) >>> Maybe rewrite the loop instead? >>>   for (i = s->nb_streams; i-- > 0;) >> >> Or >> >>    for (i = s->nb_stream

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Marton Balint
On Sat, 15 Feb 2020, Nicolas George wrote: Marton Balint (12020-02-15): +if (s->nb_streams) for (i = s->nb_streams - 1; i >= 0; i--) Maybe rewrite the loop instead? for (i = s->nb_streams; i-- > 0;) Or for (i = s->nb_streams - 1; i < s->nb_streams; i--) Or simply change

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Nicolas George
Marton Balint (12020-02-15): > > +if (s->nb_streams) > > for (i = s->nb_streams - 1; i >= 0; i--) > Maybe rewrite the loop instead? > for (i = s->nb_streams; i-- > 0;) Or for (i = s->nb_streams - 1; i < s->nb_streams; i--) Regards, -- Nicolas George signature.asc Descript

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Marton Balint
On Sat, 15 Feb 2020, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavformat/utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 81ea239a66..ba2621aa28 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4450,10 +4450

[FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

2020-02-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 81ea239a66..ba2621aa28 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4450,10 +4450,12 @@ void avformat_free_context(AVFormatCo