Re: [FFmpeg-devel] [PATCH 1/2] avformat/mux: Remove redundant checks for write errors

2020-03-14 Thread Michael Niedermayer
On Thu, Mar 12, 2020 at 06:54:07PM +0100, Andreas Rheinhardt wrote: > If writing a packet didn't directly return an error, the AVIOContext's > error flag is checked for errors (if existing) by write_packet(). And if > write_packet() didn't indicate an error, its callers checked the error > flag of

[FFmpeg-devel] [PATCH 1/2] avformat/mux: Remove redundant checks for write errors

2020-03-12 Thread Andreas Rheinhardt
If writing a packet didn't directly return an error, the AVIOContext's error flag is checked for errors (if existing) by write_packet(). And if write_packet() didn't indicate an error, its callers checked the error flag of the AVIOContext (if existing). The latter check is redundant. The reason fo