On Mon, 30 May 2016, Michael Niedermayer wrote:
On Sun, May 29, 2016 at 05:17:13PM +0200, Marton Balint wrote:
The second one is not explicitly needed, as res is not reset, but it is there
for consistency.
Signed-off-by: Marton Balint
---
libavformat/movenc.c | 6 --
1 file changed, 4 i
On Sun, May 29, 2016 at 05:17:13PM +0200, Marton Balint wrote:
> The second one is not explicitly needed, as res is not reset, but it is there
> for consistency.
>
> Signed-off-by: Marton Balint
> ---
> libavformat/movenc.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
LGTM if t
Marton Balint passwd.hu> writes:
> -res = shift_data(s);
> +if ((res = shift_data(s)) < 0)
It's not my code but "if (res < 0)" is imo easier to read,
less error-prone and makes the patch smaller...
Carl Eugen
___
ffmpeg-devel
The second one is not explicitly needed, as res is not reset, but it is there
for consistency.
Signed-off-by: Marton Balint
---
libavformat/movenc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 49cd1bd..fbb659d 100644
