Re: [FFmpeg-devel] [PATCH 1/2] avformat/isom: update mov_mdhd_language_map

2020-06-27 Thread Carl Eugen Hoyos
Am Sa., 27. Juni 2020 um 11:02 Uhr schrieb Zhao Zhili : > > Is it better to first make the table single-column, then modify the table > items? Yes. > (The multi-column to single-column change is still hard to review and > error-prone). That should not be generally true. Carl Eugen ___

Re: [FFmpeg-devel] [PATCH 1/2] avformat/isom: update mov_mdhd_language_map

2020-06-27 Thread Zhao Zhili
> On Jun 27, 2020, at 4:00 PM, Marton Balint wrote: > > > > On Sat, 27 Jun 2020, Zhao Zhili wrote: > >> This is a map from 'Macintosh Language Codes' to 'ISO639-2/T'. Some items >> in the map are ISO639-2/B, some are ISO639-1. > > Is this a functional change or a cosmetic change? If both, t

Re: [FFmpeg-devel] [PATCH 1/2] avformat/isom: update mov_mdhd_language_map

2020-06-27 Thread Marton Balint
On Sat, 27 Jun 2020, Zhao Zhili wrote: This is a map from 'Macintosh Language Codes' to 'ISO639-2/T'. Some items in the map are ISO639-2/B, some are ISO639-1. Is this a functional change or a cosmetic change? If both, then seperate commits are preferred. German: ger => deu Dutch: dut =

[FFmpeg-devel] [PATCH 1/2] avformat/isom: update mov_mdhd_language_map

2020-06-26 Thread Zhao Zhili
This is a map from 'Macintosh Language Codes' to 'ISO639-2/T'. Some items in the map are ISO639-2/B, some are ISO639-1. German: ger => deu Dutch: dut = nld Swedish: sve => swe Icelandic: ice => isl Croatian: hr => hrv Chinese: chi => zho Faroese: fo => fao Farsi/Persian: "" => fas Flemish: "" => n