Re: [FFmpeg-devel] [PATCH 1/2] avformat/icodec: ico probe with unknown data

2016-02-19 Thread Michael Niedermayer
On Tue, Feb 16, 2016 at 01:42:50AM -0800, Mark Harris wrote: > >> Header: OK, 2 frames > >> Frame 0: Unknown (offset points beyond end of probe buffer) > >> Frame 1: Invalid > >> Previously this example had a score of 25, even though the score would > >> be 1 if the unknown frame was k

Re: [FFmpeg-devel] [PATCH 1/2] avformat/icodec: ico probe with unknown data

2016-02-16 Thread Mark Harris
>> Header: OK, 2 frames >> Frame 0: Unknown (offset points beyond end of probe buffer) >> Frame 1: Invalid >> Previously this example had a score of 25, even though the score would >> be 1 if the unknown frame was known to be valid or 0 if it was known >> to be invalid. For this examp

Re: [FFmpeg-devel] [PATCH 1/2] avformat/icodec: ico probe with unknown data

2016-02-16 Thread Carl Eugen Hoyos
Mark Harris gmail.com> writes: > Header: OK, 2 frames > Frame 0: Unknown (offset points beyond end of probe buffer) > Frame 1: Invalid > Previously this example had a score of 25, even though the score would > be 1 if the unknown frame was known to be valid or 0 if it was known > to

[FFmpeg-devel] [PATCH 1/2] avformat/icodec: ico probe with unknown data

2016-02-15 Thread Mark Harris
Fix cases where unknown data (data beyond p->buf_size) could produce a higher ico probe score than if the unknown data was known and valid. For example: Header: OK, 2 frames Frame 0: Unknown (offset points beyond end of probe buffer) Frame 1: Invalid Previously this example had a score