Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-27 Thread Paul B Mahol
On 11/27/19, Tomas Härdin wrote: > ons 2019-11-27 klockan 20:00 +0100 skrev Paul B Mahol: >> On 11/27/19, James Almer wrote: >> > On 11/27/2019 3:42 PM, Paul B Mahol wrote: >> > > On 11/27/19, Tomas Härdin wrote: >> > > > tis 2019-11-26 klockan 20:29 +0100 skrev Paul B Mahol: >> > > > > On 11/26

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-27 Thread Tomas Härdin
ons 2019-11-27 klockan 20:00 +0100 skrev Paul B Mahol: > On 11/27/19, James Almer wrote: > > On 11/27/2019 3:42 PM, Paul B Mahol wrote: > > > On 11/27/19, Tomas Härdin wrote: > > > > tis 2019-11-26 klockan 20:29 +0100 skrev Paul B Mahol: > > > > > On 11/26/19, James Almer wrote: > > > > > > On 1

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-27 Thread Paul B Mahol
On 11/27/19, James Almer wrote: > On 11/27/2019 3:42 PM, Paul B Mahol wrote: >> On 11/27/19, Tomas Härdin wrote: >>> tis 2019-11-26 klockan 20:29 +0100 skrev Paul B Mahol: On 11/26/19, James Almer wrote: > On 11/26/2019 6:47 AM, Paul B Mahol wrote: >> On 11/25/19, Tomas Härdin wrot

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-27 Thread James Almer
On 11/27/2019 3:42 PM, Paul B Mahol wrote: > On 11/27/19, Tomas Härdin wrote: >> tis 2019-11-26 klockan 20:29 +0100 skrev Paul B Mahol: >>> On 11/26/19, James Almer wrote: On 11/26/2019 6:47 AM, Paul B Mahol wrote: > On 11/25/19, Tomas Härdin wrote: >> mån 2019-11-25 klockan 22:09 +

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-27 Thread Paul B Mahol
On 11/27/19, Tomas Härdin wrote: > tis 2019-11-26 klockan 20:29 +0100 skrev Paul B Mahol: >> On 11/26/19, James Almer wrote: >> > On 11/26/2019 6:47 AM, Paul B Mahol wrote: >> > > On 11/25/19, Tomas Härdin wrote: >> > > > mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: >> > > > > Signed-o

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-27 Thread Tomas Härdin
tis 2019-11-26 klockan 20:29 +0100 skrev Paul B Mahol: > On 11/26/19, James Almer wrote: > > On 11/26/2019 6:47 AM, Paul B Mahol wrote: > > > On 11/25/19, Tomas Härdin wrote: > > > > mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: > > > > > Signed-off-by: Paul B Mahol > > > > > +static in

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread Paul B Mahol
On 11/26/19, James Almer wrote: > On 11/25/2019 6:09 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/Makefile | 1 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/avcodec.h| 1 + >> libavcodec/codec_desc.c | 7 ++ >> libavcodec/midivid.c| 272 +++

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread Paul B Mahol
On 11/26/19, James Almer wrote: > On 11/26/2019 4:29 PM, Paul B Mahol wrote: >> On 11/26/19, James Almer wrote: >>> On 11/26/2019 6:47 AM, Paul B Mahol wrote: On 11/25/19, Tomas Härdin wrote: > mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: >> Signed-off-by: Paul B Mahol >>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread James Almer
On 11/26/2019 4:29 PM, Paul B Mahol wrote: > On 11/26/19, James Almer wrote: >> On 11/26/2019 6:47 AM, Paul B Mahol wrote: >>> On 11/25/19, Tomas Härdin wrote: mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: > Signed-off-by: Paul B Mahol > +static int decode_mvdv(MidiVidConte

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread Paul B Mahol
On 11/26/19, James Almer wrote: > On 11/26/2019 6:47 AM, Paul B Mahol wrote: >> On 11/25/19, Tomas Härdin wrote: >>> mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: Signed-off-by: Paul B Mahol +static int decode_mvdv(MidiVidContext *s, AVCodecContext *avctx, AVFrame *f

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread James Almer
On 11/25/2019 6:09 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 ++ > libavcodec/midivid.c| 272 > l

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread James Almer
On 11/26/2019 6:47 AM, Paul B Mahol wrote: > On 11/25/19, Tomas Härdin wrote: >> mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: >>> Signed-off-by: Paul B Mahol >>> +static int decode_mvdv(MidiVidContext *s, AVCodecContext *avctx, AVFrame >>> *frame) >>> +{ >>> +GetByteContext *gb = &s

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread Paul B Mahol
On 11/26/19, Nicolas George wrote: > Paul B Mahol (12019-11-26): >> >> Nothing of this can actually happen. >> > Then you could add asserts (and cut your quotes). >> Asserts for checking UBs? Non sense. > > Assert to have debug builds check that the things you say cannot happen > do not actually h

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread Nicolas George
Paul B Mahol (12019-11-26): > >> Nothing of this can actually happen. > > Then you could add asserts (and cut your quotes). > Asserts for checking UBs? Non sense. Assert to have debug builds check that the things you say cannot happen do not actually happen. That is what asserts are for: check a c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread Paul B Mahol
On 11/26/19, Carl Eugen Hoyos wrote: > Am Di., 26. Nov. 2019 um 10:53 Uhr schrieb Paul B Mahol : >> >> On 11/25/19, Tomas Härdin wrote: >> > mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: >> >> Signed-off-by: Paul B Mahol >> >> +static int decode_mvdv(MidiVidContext *s, AVCodecContext *a

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread Carl Eugen Hoyos
Am Di., 26. Nov. 2019 um 10:53 Uhr schrieb Paul B Mahol : > > On 11/25/19, Tomas Härdin wrote: > > mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: > >> Signed-off-by: Paul B Mahol > >> +static int decode_mvdv(MidiVidContext *s, AVCodecContext *avctx, AVFrame > >> *frame) > >> +{ > >> +

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-26 Thread Paul B Mahol
On 11/25/19, Tomas Härdin wrote: > mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: >> Signed-off-by: Paul B Mahol >> +static int decode_mvdv(MidiVidContext *s, AVCodecContext *avctx, AVFrame >> *frame) >> +{ >> +GetByteContext *gb = &s->gb; >> +GetBitContext mask; >> +GetByteCo

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-25 Thread Tomas Härdin
mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: > Signed-off-by: Paul B Mahol > +static int decode_mvdv(MidiVidContext *s, AVCodecContext *avctx, AVFrame > *frame) > +{ > +GetByteContext *gb = &s->gb; > +GetBitContext mask; > +GetByteContext idx9; > +uint16_t nb_vectors, in

[FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/midivid.c| 272 libavformat/riff.c | 1 + 6 files changed, 283 insert