Re: [FFmpeg-devel] [PATCH 1/2] avcodec/x86: move simple_idct to external assembly

2017-05-30 Thread Michael Niedermayer
On Mon, May 29, 2017 at 09:44:21PM -0400, Ronald S. Bultje wrote: > Hi, > > On Mon, May 29, 2017 at 5:26 PM, Michael Niedermayer > wrote: > > > On Mon, May 29, 2017 at 09:40:49PM +0200, James Darnley wrote: > > > On 2017-05-29 16:51, James Darnley wrote: > > > > --- > > > > Changes: > > > > - C

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/x86: move simple_idct to external assembly

2017-05-30 Thread James Darnley
On 2017-05-29 23:26, Michael Niedermayer wrote: > On Mon, May 29, 2017 at 09:40:49PM +0200, James Darnley wrote: >> On 2017-05-29 16:51, James Darnley wrote: >>> --- >>> Changes: >>> - Changed type of d4 constant to dwords because it gets used as dwords. >>> - Changed or removed HAVE_MMX_INLI

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/x86: move simple_idct to external assembly

2017-05-29 Thread Ronald S. Bultje
Hi, On Mon, May 29, 2017 at 5:26 PM, Michael Niedermayer wrote: > On Mon, May 29, 2017 at 09:40:49PM +0200, James Darnley wrote: > > On 2017-05-29 16:51, James Darnley wrote: > > > --- > > > Changes: > > > - Changed type of d4 constant to dwords because it gets used as > dwords. > > > - Ch

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/x86: move simple_idct to external assembly

2017-05-29 Thread Michael Niedermayer
On Mon, May 29, 2017 at 04:51:32PM +0200, James Darnley wrote: > --- > Changes: > - Changed type of d4 constant to dwords because it gets used as dwords. > - Changed or removed HAVE_MMX_INLINE preprocessor guards. > - Added note about conversion from inline. > - New file no longer has "2" s

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/x86: move simple_idct to external assembly

2017-05-29 Thread Michael Niedermayer
On Mon, May 29, 2017 at 09:40:49PM +0200, James Darnley wrote: > On 2017-05-29 16:51, James Darnley wrote: > > --- > > Changes: > > - Changed type of d4 constant to dwords because it gets used as dwords. > > - Changed or removed HAVE_MMX_INLINE preprocessor guards. > > - Added note about con

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/x86: move simple_idct to external assembly

2017-05-29 Thread James Darnley
On 2017-05-29 16:51, James Darnley wrote: > --- > Changes: > - Changed type of d4 constant to dwords because it gets used as dwords. > - Changed or removed HAVE_MMX_INLINE preprocessor guards. > - Added note about conversion from inline. > - New file no longer has "2" suffix. > - Whitespac

[FFmpeg-devel] [PATCH 1/2] avcodec/x86: move simple_idct to external assembly

2017-05-29 Thread James Darnley
--- Changes: - Changed type of d4 constant to dwords because it gets used as dwords. - Changed or removed HAVE_MMX_INLINE preprocessor guards. - Added note about conversion from inline. - New file no longer has "2" suffix. - Whitespace (indentation and alignment). libavcodec/tests/x86/dc