Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-14 Thread Tyler Jones
On Fri, Jul 14, 2017 at 12:43:26AM +0200, Michael Niedermayer wrote: > On Wed, Jul 12, 2017 at 04:18:06PM -0600, Tyler Jones wrote: > [...] > > > > +av_cold int psy_vorbis_init(VorbisPsyContext *vpctx, int sample_rate, > > +int channels, int blocks) > > non static fun

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-13 Thread Michael Niedermayer
On Wed, Jul 12, 2017 at 04:18:06PM -0600, Tyler Jones wrote: [...] > +av_cold int psy_vorbis_init(VorbisPsyContext *vpctx, int sample_rate, > +int channels, int blocks) non static functions needs a prefix in this case ff_ [...] -- Michael GnuPG fingerprint: 9F

[FFmpeg-devel] [PATCH 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-12 Thread Tyler Jones
The encoder will attempt to determine the existence of transient signals by applying a 4th order highpass filter to remove dominant low frequency waveforms. Frames are then split up into blocks where the variance is calculated and compared with blocks from the previous frame. A preecho is only like