Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvdsub: fix partial packet assembly

2015-09-22 Thread wm4
On Mon, 21 Sep 2015 18:25:30 +0200 wm4 wrote: > Assuming the first and second packets are partial, this would append the > reassembly buffer (ctx->buf) to itself with the second > append_to_cached_buf() call, because buf is set to ctx->buf. > > I do not know a valid sample file which triggers th

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvdsub: fix partial packet assembly

2015-09-21 Thread wm4
On Mon, 21 Sep 2015 21:15:23 +0200 Michael Niedermayer wrote: > On Mon, Sep 21, 2015 at 06:25:30PM +0200, wm4 wrote: > > Assuming the first and second packets are partial, this would append the > > reassembly buffer (ctx->buf) to itself with the second > > append_to_cached_buf() call, because buf

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvdsub: fix partial packet assembly

2015-09-21 Thread Michael Niedermayer
On Mon, Sep 21, 2015 at 06:25:30PM +0200, wm4 wrote: > Assuming the first and second packets are partial, this would append the > reassembly buffer (ctx->buf) to itself with the second > append_to_cached_buf() call, because buf is set to ctx->buf. > > I do not know a valid sample file which trigge

[FFmpeg-devel] [PATCH 1/2] avcodec/dvdsub: fix partial packet assembly

2015-09-21 Thread wm4
Assuming the first and second packets are partial, this would append the reassembly buffer (ctx->buf) to itself with the second append_to_cached_buf() call, because buf is set to ctx->buf. I do not know a valid sample file which triggers this, and do not know if packets can be split into more than