On 24/12/2018 08:41, Guo, Yejun wrote:
>>> +size_t nb_rois = frame->rois_buf->size /
>>> + sizeof(AVFrameROI);
>>
>> I think we have some macros that do this already.
>
> I tried a code search and do not find one, there is a similar macro which
> does not work for this case: #
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Derek Buitenhuis
> Sent: Saturday, December 22, 2018 12:36 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 1/2] add support for ROI-based
> encodin
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Mark Thompson
> Sent: Friday, December 21, 2018 5:08 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 1/2] add support for ROI-based
> encoding
>
2018-12-21 17:36 GMT+01:00, Derek Buitenhuis :
> On 12/12/2018 16:26, Guo, Yejun wrote:
>> +if (frame->rois_buf != NULL) {
>> +if (x4->params.rc.i_aq_mode == X264_AQ_NONE) {
>> +av_log(ctx, AV_LOG_ERROR, "Adaptive quantization
>> must be enabled to use ROI encod
A few comments below.
On 12/12/2018 16:26, Guo, Yejun wrote:
> +if (frame->rois_buf != NULL) {
> +if (x4->params.rc.i_aq_mode == X264_AQ_NONE) {
> +av_log(ctx, AV_LOG_ERROR, "Adaptive quantization must be
> enabled to use ROI encoding, skipping ROI.\n");
This
On 12/12/2018 16:26, Guo, Yejun wrote:
> This patchset contains two patches.
> - the first patch (this patch) finished the code and ask for upstream.
> - the second patch is just a quick example on how to generate ROI info.
>
> The encoders such as libx264 support different QPs offset for differen
aks for review, thanks.
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Guo, Yejun
> Sent: Thursday, December 13, 2018 12:26 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 1/2] add support for
This patchset contains two patches.
- the first patch (this patch) finished the code and ask for upstream.
- the second patch is just a quick example on how to generate ROI info.
The encoders such as libx264 support different QPs offset for different MBs,
it makes possible for ROI-based encoding.
