Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

On 1/4/2019 11:45 PM, Rostislav Pehlivanov wrote: > On Fri, 4 Jan 2019 at 23:19, Mohammad Izadi wrote: > >> Thanks James. >> -- >> Best, >> Mohammad >> >> >> On Fri, Jan 4, 2019 at 3:03 PM James Almer wrote: >> >>> On 1/4/2019 7:51 PM, Rostislav Pehlivanov wrote: On Fri, 4 Jan 2019 at 21:08

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

On Fri, 4 Jan 2019 at 23:19, Mohammad Izadi wrote: > Thanks James. > -- > Best, > Mohammad > > > On Fri, Jan 4, 2019 at 3:03 PM James Almer wrote: > > > On 1/4/2019 7:51 PM, Rostislav Pehlivanov wrote: > > > On Fri, 4 Jan 2019 at 21:08, James Almer wrote: > > > > > >> On 1/4/2019 3:53 PM, Rosti

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

Thanks James. -- Best, Mohammad On Fri, Jan 4, 2019 at 3:03 PM James Almer wrote: > On 1/4/2019 7:51 PM, Rostislav Pehlivanov wrote: > > On Fri, 4 Jan 2019 at 21:08, James Almer wrote: > > > >> On 1/4/2019 3:53 PM, Rostislav Pehlivanov wrote: > >>> On Fri, 4 Jan 2019 at 18:12, Mohammad Izadi

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

Hi Rostislav, It seems there is a bit miscommunication here. I dont want to create a full struct. However, as James mentioned too, Content Light and Dynamic HDR10+ are two different SEI types. There's no reason to merge them into a single struct within the HEVC decoder. I mean to create the foll

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

On 1/4/2019 7:51 PM, Rostislav Pehlivanov wrote: > On Fri, 4 Jan 2019 at 21:08, James Almer wrote: > >> On 1/4/2019 3:53 PM, Rostislav Pehlivanov wrote: >>> On Fri, 4 Jan 2019 at 18:12, Mohammad Izadi wrote: >>> You mean a pointer in HEVCSEIDynamicHDRPlus, not in HEVCSEIContentLight? -

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

On Fri, 4 Jan 2019 at 21:08, James Almer wrote: > On 1/4/2019 3:53 PM, Rostislav Pehlivanov wrote: > > On Fri, 4 Jan 2019 at 18:12, Mohammad Izadi wrote: > > > >> You mean a pointer in HEVCSEIDynamicHDRPlus, not in HEVCSEIContentLight? > >> -- > >> Best, > >> Mohammad > >> > >> > >> On Thu, Jan

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

On 1/4/2019 3:53 PM, Rostislav Pehlivanov wrote: > On Fri, 4 Jan 2019 at 18:12, Mohammad Izadi wrote: > >> You mean a pointer in HEVCSEIDynamicHDRPlus, not in HEVCSEIContentLight? >> -- >> Best, >> Mohammad >> >> >> On Thu, Jan 3, 2019 at 5:08 PM Rostislav Pehlivanov >> wrote: >> >>> On Thu, 3 J

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

On 1/4/2019 2:51 PM, Mohammad Izadi wrote: > I did that before and James ask me to copy. So now, James are you OK with > that? Your first patch allocated a second AVDynamicHDRPlus and memcpy'd everything to the new one every frame. Rostislav suggestion is to allocate a single AVDynamicHDRPlus, make

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

I like your idea of using AVBufferRef. Thanks for that. However, I prefer both HEVCSEIContentLight and HEVCSEIDynamicHDRPlus exist, because ContentLight and Dynamic HDR10+ are two different things. For a frame, we can have both or none of them or only one of them. It would be more complex to set th

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

On Fri, 4 Jan 2019 at 18:12, Mohammad Izadi wrote: > You mean a pointer in HEVCSEIDynamicHDRPlus, not in HEVCSEIContentLight? > -- > Best, > Mohammad > > > On Thu, Jan 3, 2019 at 5:08 PM Rostislav Pehlivanov > wrote: > > > On Thu, 3 Jan 2019 at 20:13, Mohammad Izadi wrote: > > > > > > > > /**

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

You mean a pointer in HEVCSEIDynamicHDRPlus, not in HEVCSEIContentLight? -- Best, Mohammad On Thu, Jan 3, 2019 at 5:08 PM Rostislav Pehlivanov wrote: > On Thu, 3 Jan 2019 at 20:13, Mohammad Izadi wrote: > > > > > /** > > @@ -94,6 +95,50 @@ typedef struct HEVCSEIMasteringDisplay { > > uin

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

I did that before and James ask me to copy. So now, James are you OK with that? -- Best, Mohammad On Thu, Jan 3, 2019 at 5:08 PM Rostislav Pehlivanov wrote: > On Thu, 3 Jan 2019 at 20:13, Mohammad Izadi wrote: > > > > > /** > > @@ -94,6 +95,50 @@ typedef struct HEVCSEIMasteringDisplay { > >

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

On 1/3/2019 10:07 PM, Rostislav Pehlivanov wrote: > On Thu, 3 Jan 2019 at 20:13, Mohammad Izadi wrote: > >> >> /** >> @@ -94,6 +95,50 @@ typedef struct HEVCSEIMasteringDisplay { >> uint32_t min_luminance; >> } HEVCSEIMasteringDisplay; >> >> +typedef struct HEVCSEIDynamicHDRPlus{ >> +in

Re: [FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

On Thu, 3 Jan 2019 at 20:13, Mohammad Izadi wrote: > > /** > @@ -94,6 +95,50 @@ typedef struct HEVCSEIMasteringDisplay { > uint32_t min_luminance; > } HEVCSEIMasteringDisplay; > > +typedef struct HEVCSEIDynamicHDRPlus{ > +int present; > +uint8_t itu_t_t35_country_code; > +uint8

[FFmpeg-devel] [PATCH 1/2] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

--- libavcodec/hevc_sei.c | 219 -- libavcodec/hevc_sei.h | 46 + libavcodec/hevcdec.c | 195 + 3 files changed, 454 insertions(+), 6 deletions(-) diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c index