Re: [FFmpeg-devel] [PATCH 1/2] Expose and start using skip_remaining

2023-09-11 Thread Christophe Gisquet
Hello, Le ven. 8 sept. 2023 à 00:39, Andreas Rheinhardt a écrit : > This is problematic, because you seem to think that bits_peek(bc, bits) > ensures that there are at least `bits` available in the cache; read_vlc* also makes that assumption? Anyway, I'd put that behaviour (of checking) under (!

Re: [FFmpeg-devel] [PATCH 1/2] Expose and start using skip_remaining

2023-09-07 Thread Andreas Rheinhardt
Christophe Gisquet: > Bitstream readers sometimes have already checked there are enough > bits, and the check is redundant. This patch aims to do two things; and these should be in separate patches so that one can see immediately where you just change the name and where you change the actual code.

[FFmpeg-devel] [PATCH 1/2] Expose and start using skip_remaining

2023-09-07 Thread Christophe Gisquet
Bitstream readers sometimes have already checked there are enough bits, and the check is redundant. --- libavcodec/bitstream.h | 8 +--- libavcodec/bitstream_template.h | 22 +++--- libavcodec/get_bits.h | 1 + 3 files changed, 17 insertions(+), 14 deletion