Re: [FFmpeg-devel] [PATCH 1/2] Add an OpenH264 decoder wrapper

2016-07-27 Thread Martin Storsjö
On Tue, 26 Jul 2016, Michael Niedermayer wrote: On Tue, Jul 26, 2016 at 09:31:17PM +0300, Martin Storsjö wrote: This is cherrypicked from libav, from commits 82b7525173f20702a8cbc26ebedbf4b69b8fecec and d0b1e6049b06ca146ece4d2f199c5dba1565. --- Fixed the issues pointed out by Michael, remo

Re: [FFmpeg-devel] [PATCH 1/2] Add an OpenH264 decoder wrapper

2016-07-26 Thread Michael Niedermayer
On Tue, Jul 26, 2016 at 09:31:17PM +0300, Martin Storsjö wrote: > This is cherrypicked from libav, from commits > 82b7525173f20702a8cbc26ebedbf4b69b8fecec and > d0b1e6049b06ca146ece4d2f199c5dba1565. > > --- > Fixed the issues pointed out by Michael, removed the parts of the > commit message as

[FFmpeg-devel] [PATCH 1/2] Add an OpenH264 decoder wrapper

2016-07-26 Thread Martin Storsjö
This is cherrypicked from libav, from commits 82b7525173f20702a8cbc26ebedbf4b69b8fecec and d0b1e6049b06ca146ece4d2f199c5dba1565. --- Fixed the issues pointed out by Michael, removed the parts of the commit message as requested by Carl. --- Changelog | 1 + configure

Re: [FFmpeg-devel] [PATCH 1/2] Add an OpenH264 decoder wrapper

2016-07-26 Thread Michael Niedermayer
On Tue, Jul 26, 2016 at 03:41:52PM +0300, Martin Storsjö wrote: [...] > +static int svc_decode_frame(AVCodecContext *avctx, void *data, > +int *got_frame, AVPacket *avpkt) > +{ > +SVCContext *s = avctx->priv_data; > +SBufferInfo info = { 0 }; > +uint8_t* ptr

Re: [FFmpeg-devel] [PATCH 1/2] Add an OpenH264 decoder wrapper

2016-07-26 Thread Michael Niedermayer
On Tue, Jul 26, 2016 at 10:30:48AM -0400, compn wrote: > On Tue, 26 Jul 2016 14:06:57 + (UTC) > Carl Eugen Hoyos wrote: > > > > one could potentially want to use it to take advantage > > > of the cisco patent license offer. > > > > I am not sure I understand this, could you elaborate? > > In

Re: [FFmpeg-devel] [PATCH 1/2] Add an OpenH264 decoder wrapper

2016-07-26 Thread Carl Eugen Hoyos
compn mi.rr.com> writes: > > > one could potentially want to use it to take advantage > > > of the cisco patent license offer. > > > > I am not sure I understand this, could you elaborate? > > In any case, this should imo not be part of the commit > > message. > > http://www.openh264.org/faq.h

Re: [FFmpeg-devel] [PATCH 1/2] Add an OpenH264 decoder wrapper

2016-07-26 Thread compn
On Tue, 26 Jul 2016 14:06:57 + (UTC) Carl Eugen Hoyos wrote: > > one could potentially want to use it to take advantage > > of the cisco patent license offer. > > I am not sure I understand this, could you elaborate? > In any case, this should imo not be part of the commit > message. http:

Re: [FFmpeg-devel] [PATCH 1/2] Add an OpenH264 decoder wrapper

2016-07-26 Thread Carl Eugen Hoyos
Hi! Martin Storsjö martin.st> writes: > While it is less featureful (and slower) than the > built-in H264 decoder, I don't think this is an issue, having an additional decoder can make testing issues much easier. > one could potentially want to use it to take advantage > of the cisco patent

[FFmpeg-devel] [PATCH 1/2] Add an OpenH264 decoder wrapper

2016-07-26 Thread Martin Storsjö
While it is less featureful (and slower) than the built-in H264 decoder, one could potentially want to use it to take advantage of the cisco patent license offer. This is cherrypicked from libav, from commits 82b7525173f20702a8cbc26ebedbf4b69b8fecec and d0b1e6049b06ca146ece4d2f199c5dba1565. --