Re: [FFmpeg-devel] [PATCH 09/18] vp3: eliminate copy_fields

2020-03-14 Thread Peter Ross
On Fri, Mar 13, 2020 at 11:28:41AM +0100, Anton Khirnov wrote: > It is very fragile against fields being moved and hides what is actually > being copied. Copy all the fields explicitly instead. > --- > libavcodec/vp3.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff

[FFmpeg-devel] [PATCH 09/18] vp3: eliminate copy_fields

2020-03-13 Thread Anton Khirnov
It is very fragile against fields being moved and hides what is actually being copied. Copy all the fields explicitly instead. --- libavcodec/vp3.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 0a8c8ad286..81d0b9b7bb 1006