Re: [FFmpeg-devel] [PATCH 09/10] avformat/matroskadec: Improve length check

2019-03-08 Thread Michael Niedermayer
On Fri, Mar 08, 2019 at 10:26:03AM +0100, Andreas Rheinhardt wrote: > The earlier code had three flaws: > > 1. The case of an unknown-sized element inside a finite-sized element > (which is against the specifications) was not caught. > > 2. The error message wasn't helpful: It compared the length

[FFmpeg-devel] [PATCH 09/10] avformat/matroskadec: Improve length check

2019-03-08 Thread Andreas Rheinhardt
The earlier code had three flaws: 1. The case of an unknown-sized element inside a finite-sized element (which is against the specifications) was not caught. 2. The error message wasn't helpful: It compared the length of the child with the offset of the end of the parent and claimed that the firs