Re: [FFmpeg-devel] [PATCH 06/17] lavfi: add ff_inlink_process_timeline().

2016-12-31 Thread Nicolas George
Le decadi 10 nivôse, an CCXXV, Michael Niedermayer a écrit : > // do some statistics, whatever > ... > if (ff_inlink_evaluate_timeline_at_frame()) { > process frame > } > pass output on > > > If we imagine a filter that processes a series of frames, lets say > for motion estimation or deinter

Re: [FFmpeg-devel] [PATCH 06/17] lavfi: add ff_inlink_process_timeline().

2016-12-30 Thread Michael Niedermayer
On Fri, Dec 30, 2016 at 12:37:41PM +0100, Nicolas George wrote: > Le nonidi 9 nivôse, an CCXXV, Michael Niedermayer a écrit : > > maybe the enabledness value should be returned by the function (too) > > It does not seem very useful at first glance, but I may be missing > something. // do some sta

Re: [FFmpeg-devel] [PATCH 06/17] lavfi: add ff_inlink_process_timeline().

2016-12-30 Thread Nicolas George
Le decadi 10 nivôse, an CCXXV, Clement Boesch a écrit : > You want a watermark to be effective only in a timerange, the second input > (the watermark) would get ignored outside that range, and the first one > pass through. This would be filter specific (FLAG_SUPPORT_TIMELINE_INTERNAL). > > That's

Re: [FFmpeg-devel] [PATCH 06/17] lavfi: add ff_inlink_process_timeline().

2016-12-30 Thread Clément Bœsch
On Fri, Dec 30, 2016 at 12:37:41PM +0100, Nicolas George wrote: [...] > In fact, I do not see how timeline could make sense for a filter with > several inputs. "Disabling" a filter means replacing it by the > pass-through filter "null", but it has a single input and output. > You want a watermark

Re: [FFmpeg-devel] [PATCH 06/17] lavfi: add ff_inlink_process_timeline().

2016-12-30 Thread Nicolas George
Le nonidi 9 nivôse, an CCXXV, Michael Niedermayer a écrit : > maybe the enabledness value should be returned by the function (too) It does not seem very useful at first glance, but I may be missing something. > how does this work with multiple inlinks ? > (dstctx / dstctx->enable / dstctx->is_dis

Re: [FFmpeg-devel] [PATCH 06/17] lavfi: add ff_inlink_process_timeline().

2016-12-29 Thread Michael Niedermayer
On Thu, Dec 29, 2016 at 03:33:52PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 34 +- > libavfilter/filters.h | 6 ++ > 2 files changed, 27 insertions(+), 13 deletions(-) > > > Changes in this commit: rename

[FFmpeg-devel] [PATCH 06/17] lavfi: add ff_inlink_process_timeline().

2016-12-29 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 34 +- libavfilter/filters.h | 6 ++ 2 files changed, 27 insertions(+), 13 deletions(-) Changes in this commit: rename ff_link -> ff_inlink and move to filters.h. Already LGTM by Michael. diff --g