Re: [FFmpeg-devel] [PATCH 05/18] lavc/dv: remove ff_dvvideo_init()

2022-08-25 Thread Anton Khirnov
Quoting Anton Khirnov (2022-08-25 11:48:27) > Quoting Andreas Rheinhardt (2022-08-24 14:27:43) > > There is actually another issue here: Encoders are not supposed to set > > chroma_sample_location at all according to the documentation. I sent a > > patch to implement this > > (https://ffmpeg.org/pi

Re: [FFmpeg-devel] [PATCH 05/18] lavc/dv: remove ff_dvvideo_init()

2022-08-25 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-08-24 14:27:43) > There is actually another issue here: Encoders are not supposed to set > chroma_sample_location at all according to the documentation. I sent a > patch to implement this > (https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298518.html -- it > als

Re: [FFmpeg-devel] [PATCH 05/18] lavc/dv: remove ff_dvvideo_init()

2022-08-24 Thread Andreas Rheinhardt
Anton Khirnov: > The function contains only two assignments, which are simpler to > duplicate into decoder and encoder. Additionally, dvdec does not use > DVVideoContext.avctx at all. > --- > libavcodec/dv.c| 10 -- > libavcodec/dv.h| 2 -- > libavcodec/dvdec.c | 4 +++- > libavc

[FFmpeg-devel] [PATCH 05/18] lavc/dv: remove ff_dvvideo_init()

2022-08-24 Thread Anton Khirnov
The function contains only two assignments, which are simpler to duplicate into decoder and encoder. Additionally, dvdec does not use DVVideoContext.avctx at all. --- libavcodec/dv.c| 10 -- libavcodec/dv.h| 2 -- libavcodec/dvdec.c | 4 +++- libavcodec/dvenc.c | 5 - 4 file