Re: [FFmpeg-devel] [PATCH 04/42] avcodec/h264_ps: Use RefStruct API for SPS/PPS

2023-10-02 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-09-28 17:49:15) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2023-09-19 21:56:56) > >> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c > >> index 5657327f0c..632f5b23b2 100644 > >> --- a/libavcodec/h264_slice.c > >> +++ b/libavcodec/h264_slice.c >

Re: [FFmpeg-devel] [PATCH 04/42] avcodec/h264_ps: Use RefStruct API for SPS/PPS

2023-09-28 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2023-09-19 21:56:56) >> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c >> index 5657327f0c..632f5b23b2 100644 >> --- a/libavcodec/h264_slice.c >> +++ b/libavcodec/h264_slice.c >> @@ -363,25 +361,16 @@ int ff_h264_update_thread_context(AVC

Re: [FFmpeg-devel] [PATCH 04/42] avcodec/h264_ps: Use RefStruct API for SPS/PPS

2023-09-28 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-09-19 21:56:56) > diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c > index 5657327f0c..632f5b23b2 100644 > --- a/libavcodec/h264_slice.c > +++ b/libavcodec/h264_slice.c > @@ -363,25 +361,16 @@ int ff_h264_update_thread_context(AVCodecContext *dst, >

[FFmpeg-devel] [PATCH 04/42] avcodec/h264_ps: Use RefStruct API for SPS/PPS

2023-09-19 Thread Andreas Rheinhardt
Avoids allocations and error checks for these allocations; e.g. syncing buffers across threads can't fail any more and needn't be checked. It also avoids having to keep H264ParamSets.pps and H264ParamSets.pps_ref and PPS.sps and PPS.sps_ref in sync and gets rid of casts and indirections. (The remo