Re: [FFmpeg-devel] [PATCH 03/13] lavc/videotoolboxenc: Remove redundant code

2016-04-10 Thread wm4
On Sun, 10 Apr 2016 08:57:11 -0400 Richard Kern wrote: > > On Apr 10, 2016, at 3:47 AM, Hendrik Leppkes wrote: > > > > On Sun, Apr 10, 2016 at 6:17 AM, Carl Eugen Hoyos wrote: > > > >> Rick Kern gmail.com> writes: > >> > >>> Don't require hardware encoding and explicitly fallback to > >

Re: [FFmpeg-devel] [PATCH 03/13] lavc/videotoolboxenc: Remove redundant code

2016-04-10 Thread Carl Eugen Hoyos
Richard Kern gmail.com> writes: > The user has to explicitly request this encoder, so it > shouldn’t fail if it’s capable of encoding. Developers seem to agree that it should fail. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH 03/13] lavc/videotoolboxenc: Remove redundant code

2016-04-10 Thread Richard Kern
> On Apr 10, 2016, at 3:47 AM, Hendrik Leppkes wrote: > > On Sun, Apr 10, 2016 at 6:17 AM, Carl Eugen Hoyos wrote: >> Rick Kern gmail.com> writes: >> >>> Don't require hardware encoding and explicitly fallback to >>> software if it fails. Enabling it without requiring it >>> will use hardware

Re: [FFmpeg-devel] [PATCH 03/13] lavc/videotoolboxenc: Remove redundant code

2016-04-10 Thread Hendrik Leppkes
On Sun, Apr 10, 2016 at 6:17 AM, Carl Eugen Hoyos wrote: > Rick Kern gmail.com> writes: > >> Don't require hardware encoding and explicitly fallback to >> software if it fails. Enabling it without requiring it >> will use hardware encoding if available. > > Hardware encoding should be required un

Re: [FFmpeg-devel] [PATCH 03/13] lavc/videotoolboxenc: Remove redundant code

2016-04-09 Thread Carl Eugen Hoyos
Rick Kern gmail.com> writes: > Don't require hardware encoding and explicitly fallback to > software if it fails. Enabling it without requiring it > will use hardware encoding if available. Hardware encoding should be required unless the user specifies something else. Carl Eugen ___

[FFmpeg-devel] [PATCH 03/13] lavc/videotoolboxenc: Remove redundant code

2016-04-09 Thread Rick Kern
Don't require hardware encoding and explicitly fallback to software if it fails. Enabling it without requiring it will use hardware encoding if available. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 20 1 file changed, 20 deletions(-) diff --git a/libavcodec