Re: [FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

2020-04-03 Thread Andreas Rheinhardt
Steve Lhomme: > On 2020-03-25 23:24, Andreas Rheinhardt wrote: >> Steve Lhomme: >>> From: Steve Lhomme >>> >>> Always use a comma at the end, order elements by value. >>> --- >>>   libavformat/matroska.h | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/libavforma

Re: [FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

2020-03-28 Thread Steve Lhomme
On 2020-03-25 23:24, Andreas Rheinhardt wrote: Steve Lhomme: From: Steve Lhomme Always use a comma at the end, order elements by value. --- libavformat/matroska.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h b/libavformat/matroska.h index 9e

Re: [FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

2020-03-27 Thread Anton Khirnov
Quoting Moritz Barsnick (2020-03-24 09:47:14) > On Sun, Mar 22, 2020 at 09:59:21 +0100, Steve Lhomme wrote: > > Always use a comma at the end, order elements by value. > > IIUC, this is strictly a C99(+) "feature", so should probably be > mentioned here: > https://ffmpeg.org/developer.html#C-langu

Re: [FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

2020-03-25 Thread Andreas Rheinhardt
Steve Lhomme: > From: Steve Lhomme > > Always use a comma at the end, order elements by value. > --- > libavformat/matroska.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/matroska.h b/libavformat/matroska.h > index 9e33e51c94..e177cd027f 100644 > ---

Re: [FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

2020-03-24 Thread Moritz Barsnick
On Sun, Mar 22, 2020 at 09:59:21 +0100, Steve Lhomme wrote: > Always use a comma at the end, order elements by value. IIUC, this is strictly a C99(+) "feature", so should probably be mentioned here: https://ffmpeg.org/developer.html#C-language-features in case "all compilers we care about" support

[FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

2020-03-22 Thread Steve Lhomme
From: Steve Lhomme Always use a comma at the end, order elements by value. --- libavformat/matroska.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h b/libavformat/matroska.h index 9e33e51c94..e177cd027f 100644 --- a/libavformat/matroska.h +++ b/lib