Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-29 Thread Jan Sebechlebsky
Hello Michael, On 06/29/2016 04:53 AM, Michael Niedermayer wrote: On Tue, Jun 28, 2016 at 01:33:13PM +0200, Nicolas George wrote: Le primidi 11 messidor, an CCXXIV, Nicolas George a écrit : Well, looking at the code, I am thinking that the current design is flawed: the extra alloc in ff_bsf_ge

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-28 Thread Michael Niedermayer
On Tue, Jun 28, 2016 at 01:33:13PM +0200, Nicolas George wrote: > Le primidi 11 messidor, an CCXXIV, Nicolas George a écrit : > > Well, looking at the code, I am thinking that the current design is flawed: > > the extra alloc in ff_bsf_get_packet() seems completely useless, and could > > be removed

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-28 Thread Jan Sebechlebsky
On 06/28/2016 12:10 PM, Nicolas George wrote: In summary: I am ok with this version IFF it works without malloc() overhead for empty lists and is reasonably simple. I think I can start to work on this. I think it can be done without dynamic allocation. Apart from that - do you think it would

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-28 Thread Nicolas George
Le primidi 11 messidor, an CCXXIV, Nicolas George a écrit : > Well, looking at the code, I am thinking that the current design is flawed: > the extra alloc in ff_bsf_get_packet() seems completely useless, and could > be removed as is without any other change in the current code, because all > curre

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-28 Thread Nicolas George
L'octidi 8 messidor, an CCXXIV, Marton Balint a écrit : > I thought your primary concern was the overhead which was discussed. It was only one reason amongst several; the other reasons are pretty much the usual benefits in the discussion between designing a new API for a new feature or fitting it

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-25 Thread Marton Balint
On Sun, 12 Jun 2016, Nicolas George wrote: Le quintidi 25 prairial, an CCXXIV, Marton Balint a écrit : So you probably don't have to support multiple filters, it is enough if you support a single one. This is not settled. I still think a specific

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-20 Thread Jan Sebechlebsky
On 06/20/2016 02:04 PM, Michael Niedermayer wrote: On Sun, Jun 12, 2016 at 04:30:50PM -0500, Rodger Combs wrote: --- libavformat/internal.h | 5 +++-- libavformat/mux.c | 45 +- libavformat/segment.c | 6 +++-- libavformat/utils.c| 59 ++

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-20 Thread Michael Niedermayer
On Sun, Jun 12, 2016 at 04:30:50PM -0500, Rodger Combs wrote: > --- > libavformat/internal.h | 5 +++-- > libavformat/mux.c | 45 +- > libavformat/segment.c | 6 +++-- > libavformat/utils.c| 59 > +- >

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-12 Thread Nicolas George
Le quintidi 25 prairial, an CCXXIV, Marton Balint a écrit : > So you probably don't have to > support multiple filters, it is enough if you support a single one. This is not settled. I still think a specific API is better than a container filter. Regard

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-12 Thread Marton Balint
On Sun, 12 Jun 2016, Rodger Combs wrote: --- libavformat/internal.h | 5 +++-- libavformat/mux.c | 45 +- libavformat/segment.c | 6 +++-- libavformat/utils.c| 59 +- 4 files changed, 91 insertions(+), 2

[FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-12 Thread Rodger Combs
--- libavformat/internal.h | 5 +++-- libavformat/mux.c | 45 +- libavformat/segment.c | 6 +++-- libavformat/utils.c| 59 +- 4 files changed, 91 insertions(+), 24 deletions(-) diff --git a/libavformat