Re: [FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

2015-08-24 Thread Claudio Freire
On Sat, Aug 22, 2015 at 4:51 AM, Nicolas George wrote: > Le quintidi 5 fructidor, an CCXXIII, Claudio Freire a écrit : > > They were included in the symbol table but only as local, the > libavcodec.v > > file makes sure to make everything not explicitly mentioned for export > > local. > > > > Tho

Re: [FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

2015-08-22 Thread Nicolas George
Le quintidi 5 fructidor, an CCXXIII, Claudio Freire a écrit : > They were included in the symbol table but only as local, the libavcodec.v > file makes sure to make everything not explicitly mentioned for export > local. > > Though it's possible that it depends on the compiler version? It depends

Re: [FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

2015-08-21 Thread Rostislav Pehlivanov
Applied with some additions Thanks. On 22 August 2015 at 02:21, Timothy Gu wrote: > --- > libavcodec/aaccoder.c| 64 > > libavcodec/aacenc_is.c | 2 +- > libavcodec/aacenc_is.h | 2 +- > libavcodec/aacenc_pred.c | 10 > libavc

Re: [FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

2015-08-21 Thread Timothy Gu
On Sat, Aug 22, 2015 at 01:05:18AM -0300, Claudio Freire wrote: > When reviewing the patches with Rostislav, I actually tested to see whether > those symbols were exported, and they weren't. exported ≠ nonstatic It's a project policy to use `ff_` prefix to signify non-exported, private, non-stati

Re: [FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

2015-08-21 Thread Claudio Freire
On Sat, Aug 22, 2015 at 1:01 AM, Timothy Gu wrote: > On Fri, Aug 21, 2015 at 10:49:01PM -0400, Ganesh Ajjanagadde wrote: > > There are too many entries here for me to verify which ones are exposed, > etc. > > I trust you identified them correctly. > > To the best of my knowledge, yes. To anyone r

Re: [FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

2015-08-21 Thread Timothy Gu
On Fri, Aug 21, 2015 at 10:49:01PM -0400, Ganesh Ajjanagadde wrote: > There are too many entries here for me to verify which ones are exposed, etc. > I trust you identified them correctly. To the best of my knowledge, yes. To anyone reading this message, I used the following command to get a list

Re: [FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

2015-08-21 Thread Ganesh Ajjanagadde
On Fri, Aug 21, 2015 at 9:21 PM, Timothy Gu wrote: > --- > libavcodec/aaccoder.c| 64 > > libavcodec/aacenc_is.c | 2 +- > libavcodec/aacenc_is.h | 2 +- > libavcodec/aacenc_pred.c | 10 > libavcodec/aacenc_pred.h | 10

[FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

2015-08-21 Thread Timothy Gu
--- libavcodec/aaccoder.c| 64 libavcodec/aacenc_is.c | 2 +- libavcodec/aacenc_is.h | 2 +- libavcodec/aacenc_pred.c | 10 libavcodec/aacenc_pred.h | 10 libavcodec/aacenc_tns.c | 4 +-- libavcodec/aacenc_tns.h | 4 +