Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread James Almer
On 3/21/2021 8:13 PM, Hendrik Leppkes wrote: On Sun, Mar 21, 2021 at 3:24 PM James Almer wrote: How about adding the deprecation attribute to prompt people to read the doxy, where we state the field is not going away, just changing types? Otherwise i don't think people will notice. I really

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread Hendrik Leppkes
On Sun, Mar 21, 2021 at 3:24 PM James Almer wrote: > > How about adding the deprecation attribute to prompt people to read the > doxy, where we state the field is not going away, just changing types? > Otherwise i don't think people will notice. I really don't like such solutions. You get warning

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread Marton Balint
On Sun, 21 Mar 2021, James Almer wrote: On 3/21/2021 3:37 PM, James Almer wrote: On 3/21/2021 3:15 PM, Marton Balint wrote: On Sun, 21 Mar 2021, James Almer wrote: On 3/21/2021 11:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-21 14:54:22) On 3/21/2021 9:28 AM, Anton Khirnov

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread James Almer
On 3/21/2021 3:37 PM, James Almer wrote: On 3/21/2021 3:15 PM, Marton Balint wrote: On Sun, 21 Mar 2021, James Almer wrote: On 3/21/2021 11:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-21 14:54:22) On 3/21/2021 9:28 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-05 17:3

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread James Almer
On 3/21/2021 3:37 PM, James Almer wrote: On 3/21/2021 3:15 PM, Marton Balint wrote: On Sun, 21 Mar 2021, James Almer wrote: On 3/21/2021 11:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-21 14:54:22) On 3/21/2021 9:28 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-05 17:3

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread James Almer
On 3/21/2021 3:15 PM, Marton Balint wrote: On Sun, 21 Mar 2021, James Almer wrote: On 3/21/2021 11:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-21 14:54:22) On 3/21/2021 9:28 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-05 17:32:52) diff --git a/libavformat/avformat.h

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread Marton Balint
On Sun, 21 Mar 2021, James Almer wrote: On 3/21/2021 11:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-21 14:54:22) On 3/21/2021 9:28 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-05 17:32:52) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 7da2f3d98e..

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread James Almer
On 3/21/2021 11:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-21 14:54:22) On 3/21/2021 9:28 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-05 17:32:52) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 7da2f3d98e..783cc1b591 100644 --- a/libavformat/avformat

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread James Almer
On 3/21/2021 9:28 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-05 17:32:52) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 7da2f3d98e..783cc1b591 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -954,7 +954,11 @@ typedef struct AVStream { *

[FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-05 Thread James Almer
Once removed, sizeof(AVPacket) will stop being a part of the public ABI. Signed-off-by: James Almer --- libavcodec/avpacket.c | 23 +++ libavcodec/packet.h| 22 ++ libavcodec/version.h | 5 - libavformat/avformat.h | 4 4 files changed, 4