Re: [FFmpeg-devel] [PATCH 01/18] mpeg4videodec: do not copy a range of fields at once

2020-03-15 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2020-03-14 13:42:33) > Am Sa., 14. März 2020 um 12:58 Uhr schrieb Paul B Mahol : > > > > On 3/14/20, Carl Eugen Hoyos wrote: > > > Am Fr., 13. März 2020 um 11:30 Uhr schrieb Anton Khirnov > > > : > > > > > > Am I really the only one who finds the code more "fragile" after

Re: [FFmpeg-devel] [PATCH 01/18] mpeg4videodec: do not copy a range of fields at once

2020-03-14 Thread Carl Eugen Hoyos
Am Sa., 14. März 2020 um 12:58 Uhr schrieb Paul B Mahol : > > On 3/14/20, Carl Eugen Hoyos wrote: > > Am Fr., 13. März 2020 um 11:30 Uhr schrieb Anton Khirnov > > : > >> > >> This is extremely fragile against reordering and hides what is actually > >> being copied. Copy all the fields manually ins

Re: [FFmpeg-devel] [PATCH 01/18] mpeg4videodec: do not copy a range of fields at once

2020-03-14 Thread Paul B Mahol
On 3/14/20, Carl Eugen Hoyos wrote: > Am Fr., 13. März 2020 um 11:30 Uhr schrieb Anton Khirnov > : >> >> This is extremely fragile against reordering and hides what is actually >> being copied. Copy all the fields manually instead. >> --- >> libavcodec/mpeg4videodec.c | 27 +++

Re: [FFmpeg-devel] [PATCH 01/18] mpeg4videodec: do not copy a range of fields at once

2020-03-14 Thread Carl Eugen Hoyos
Am Fr., 13. März 2020 um 11:30 Uhr schrieb Anton Khirnov : > > This is extremely fragile against reordering and hides what is actually > being copied. Copy all the fields manually instead. > --- > libavcodec/mpeg4videodec.c | 27 ++- > 1 file changed, 26 insertions(+), 1 de

Re: [FFmpeg-devel] [PATCH 01/18] mpeg4videodec: do not copy a range of fields at once

2020-03-13 Thread James Almer
On 3/13/2020 7:28 AM, Anton Khirnov wrote: > This is extremely fragile against reordering and hides what is actually > being copied. Copy all the fields manually instead. > --- > libavcodec/mpeg4videodec.c | 27 ++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > dif

[FFmpeg-devel] [PATCH 01/18] mpeg4videodec: do not copy a range of fields at once

2020-03-13 Thread Anton Khirnov
This is extremely fragile against reordering and hides what is actually being copied. Copy all the fields manually instead. --- libavcodec/mpeg4videodec.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4vi