Re: [FFmpeg-devel] [PATCH 01/18] cbs: Allow non-blank packets in ff_cbs_write_packet

2019-06-17 Thread James Almer
On 6/17/2019 11:34 AM, Andreas Rheinhardt wrote: > James Almer: >> On 6/17/2019 9:44 AM, James Almer wrote: >>> On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: Up until now, ff_cbs_write_packet always initialized the packet structure it received without documenting this behaviour; furthe

Re: [FFmpeg-devel] [PATCH 01/18] cbs: Allow non-blank packets in ff_cbs_write_packet

2019-06-17 Thread Andreas Rheinhardt
James Almer: > On 6/17/2019 9:44 AM, James Almer wrote: >> On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: >>> Up until now, ff_cbs_write_packet always initialized the packet >>> structure it received without documenting this behaviour; furthermore, >>> the packet's buffer would (on success) be ov

Re: [FFmpeg-devel] [PATCH 01/18] cbs: Allow non-blank packets in ff_cbs_write_packet

2019-06-17 Thread James Almer
On 6/17/2019 9:44 AM, James Almer wrote: > On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: >> Up until now, ff_cbs_write_packet always initialized the packet >> structure it received without documenting this behaviour; furthermore, >> the packet's buffer would (on success) be overwritten with the

Re: [FFmpeg-devel] [PATCH 01/18] cbs: Allow non-blank packets in ff_cbs_write_packet

2019-06-17 Thread James Almer
On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: > Up until now, ff_cbs_write_packet always initialized the packet > structure it received without documenting this behaviour; furthermore, > the packet's buffer would (on success) be overwritten with the new > buffer without unreferencing the old. Th

[FFmpeg-devel] [PATCH 01/18] cbs: Allow non-blank packets in ff_cbs_write_packet

2019-06-16 Thread Andreas Rheinhardt
Up until now, ff_cbs_write_packet always initialized the packet structure it received without documenting this behaviour; furthermore, the packet's buffer would (on success) be overwritten with the new buffer without unreferencing the old. This meant that the input packet had to be either clean (ot