Re: [FFmpeg-devel] [PATCH 01/14] avutil/opt: add AV_OPT_FLAG_RUNTIME_PARAM flag

2019-10-13 Thread Nicolas George
Paul B Mahol (12019-10-13): > R is already taken for realtime option. > Another patch uses T for this. I meant the code you did use in the other patch, I neglected to check. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 01/14] avutil/opt: add AV_OPT_FLAG_RUNTIME_PARAM flag

2019-10-13 Thread Paul B Mahol
On 10/13/19, Nicolas George wrote: > Paul B Mahol (12019-10-10): >> Signed-off-by: Paul B Mahol >> --- >> libavutil/opt.h | 1 + >> 1 file changed, 1 insertion(+) > > The patch series looks reasonable on the whole. It changes the return > code of process_command() in a few cases, but that should

Re: [FFmpeg-devel] [PATCH 01/14] avutil/opt: add AV_OPT_FLAG_RUNTIME_PARAM flag

2019-10-13 Thread Nicolas George
Paul B Mahol (12019-10-10): > Signed-off-by: Paul B Mahol > --- > libavutil/opt.h | 1 + > 1 file changed, 1 insertion(+) The patch series looks reasonable on the whole. It changes the return code of process_command() in a few cases, but that should not have consequences. But it is completely m

[FFmpeg-devel] [PATCH 01/14] avutil/opt: add AV_OPT_FLAG_RUNTIME_PARAM flag

2019-10-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavutil/opt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index 39f4a8dda0..bc98ab104d 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -288,6 +288,7 @@ typedef struct AVOption { */ #define AV_OPT_FLAG_READONLY