Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-22 Thread Michael Niedermayer
On Fri, Aug 22, 2014 at 02:04:36PM +0200, Mickaël Raulet wrote: > for the whole patchset. all applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by a

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-22 Thread Mickaël Raulet
for the whole patchset. Mickaël Le 22 août 2014 à 13:25, Michael Niedermayer a écrit : > On Fri, Aug 22, 2014 at 11:40:17AM +0200, Mickaël Raulet wrote: >> Patch okay. > > patch applied > > just to make sure i dont misunderstand, that "okay" was just for this > patch or the whole patchset ? >

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-22 Thread Michael Niedermayer
On Fri, Aug 22, 2014 at 11:40:17AM +0200, Mickaël Raulet wrote: > Patch okay. patch applied just to make sure i dont misunderstand, that "okay" was just for this patch or the whole patchset ? thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-22 Thread Mickaël Raulet
Patch okay. Mickaël Le 4 août 2014 à 10:31, Christophe Gisquet a écrit : > Hi, > > 2014-08-02 14:48 GMT+02:00 Michael Niedermayer : >> seems to fail with >> libavcodec/x86/hevc_mc.asm:1258: error: (add:2) cannot reference symbol >> `MAX_PB_SIZE' in preprocessor > > I forgot the initial patch

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-21 Thread Christophe Gisquet
Hi, 2014-08-04 15:20 GMT+02:00 Michael Niedermayer : > cc-ing Mickael, so its not missed Ping. The objection was mostly that openhevc was working on some arm optimization. That should be pretty easy even for Mickael, considering this code: https://github.com/OpenHEVC/FFmpeg/blob/rext/libavcodec/

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-04 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 07:10:13PM +0200, Christophe Gisquet wrote: > Hi, > > 2014-08-02 14:48 GMT+02:00 Michael Niedermayer : > > is this for apply/push or just RFC/WIP ? > > in-between. I had expected Mickael Raulet to comment if he was seeing > something not compatible with this. I think the b

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-04 Thread Michael Niedermayer
On Mon, Aug 04, 2014 at 10:31:52AM +0200, Christophe Gisquet wrote: > Hi, > > 2014-08-02 14:48 GMT+02:00 Michael Niedermayer : > > seems to fail with > > libavcodec/x86/hevc_mc.asm:1258: error: (add:2) cannot reference symbol > > `MAX_PB_SIZE' in preprocessor > > I forgot the initial patch when

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-04 Thread Christophe Gisquet
Hi, 2014-08-02 14:48 GMT+02:00 Michael Niedermayer : > seems to fail with > libavcodec/x86/hevc_mc.asm:1258: error: (add:2) cannot reference symbol > `MAX_PB_SIZE' in preprocessor I forgot the initial patch when generating the patchset, that you can find here. I expect no changes for the others,

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-03 Thread Christophe Gisquet
Hi, 2014-08-02 14:48 GMT+02:00 Michael Niedermayer : > is this for apply/push or just RFC/WIP ? in-between. I had expected Mickael Raulet to comment if he was seeing something not compatible with this. I think the bipred code is a bit more mature since Ronald comments (iirc), so premature optimiz

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-02 Thread Michael Niedermayer
On Mon, Jul 28, 2014 at 05:17:24PM +, Christophe Gisquet wrote: > MAX_PB_SIZE is used or assumed for various buffer strides. In some cases, > it is used as constant parameter(s) to functions. > > Make use of that knowledge to: > - not pass the parameter > - avoid extra GPR usage > - precompute

[FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-07-28 Thread Christophe Gisquet
MAX_PB_SIZE is used or assumed for various buffer strides. In some cases, it is used as constant parameter(s) to functions. Make use of that knowledge to: - not pass the parameter - avoid extra GPR usage - precompute addresses / offsets Premature optimization and overall not that useful. Before: