Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Lynne
36 >>>> À : FFmpeg development discussions and patches >>>> Objet : Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser >>>> >>>> >>>> >>>> Changes looks trivial enough. >>>> >>> >>> If no on

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread James Almer
On 1/25/2021 12:35 PM, Lynne wrote: Jan 25, 2021, 12:03 by nicolas.gaullier@cji.paris: De : ffmpeg-devel De la part de Paul B Mahol Envoyé : jeudi 21 janvier 2021 13:36 À : FFmpeg development discussions and patches Objet : Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Lynne
Jan 25, 2021, 12:03 by nicolas.gaullier@cji.paris: > >De : ffmpeg-devel De la part de Paul B > >Mahol > >Envoyé : jeudi 21 janvier 2021 13:36 > >À : FFmpeg development discussions and patches > >Objet : Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a p

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Paul B Mahol
On Mon, Jan 25, 2021 at 12:04 PM Nicolas Gaullier wrote: > >De : ffmpeg-devel De la part de Paul B > Mahol > >Envoyé : jeudi 21 janvier 2021 13:36 > >À : FFmpeg development discussions and patches > >Objet : Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Nicolas Gaullier
>De : ffmpeg-devel De la part de Paul B Mahol >Envoyé : jeudi 21 janvier 2021 13:36 >À : FFmpeg development discussions and patches >Objet : Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser > >Changes looks trivial enough. If no one object, the two patches may be a

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-21 Thread Paul B Mahol
Changes looks trivial enough. On Thu, Jan 21, 2021 at 1:30 PM Nicolas Gaullier wrote: > >De : Nicolas Gaullier > >Envoyé : jeudi 14 janvier 2021 17:26 > >À : ffmpeg-devel@ffmpeg.org > >Cc : Nicolas Gaullier > >Objet : [PATCH 0/2] avcodec/dolby_e: Add a parser > > > >I have limited duplicated c

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-21 Thread Nicolas Gaullier
>De : Nicolas Gaullier >Envoyé : jeudi 14 janvier 2021 17:26 >À : ffmpeg-devel@ffmpeg.org >Cc : Nicolas Gaullier >Objet : [PATCH 0/2] avcodec/dolby_e: Add a parser > >I have limited duplicated code by making the decoder calling the parser. >An option would be to leave all common code to dolby_e.

[FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-14 Thread Nicolas Gaullier
I have limited duplicated code by making the decoder calling the parser. An option would be to leave all common code to dolby_e.c and move decoding to dolby_edec.c, but that would require either to duplicate 3 "very-internal" functions (skip_input/parse_key/convert_input) 3x times instead of twic