Re: [FFmpeg-devel] [PATCH]v5 Opus Pyramid Vector Quantization Search in x86 SIMD asm

2017-07-24 Thread Ivan Kalvachev
On 7/23/17, Rostislav Pehlivanov wrote: > On 22 July 2017 at 12:18, Ivan Kalvachev wrote: > >> This patch is ready for review and inclusion. >> >> >> >>+%macro emu_blendvps 3 ; dst/src_a, src_b, mask >>+%macro lea_pic_base 2; reg, const_label > Capitalize macro names. Done for the later. About t

Re: [FFmpeg-devel] [PATCH]v5 Opus Pyramid Vector Quantization Search in x86 SIMD asm

2017-07-22 Thread Rostislav Pehlivanov
On 22 July 2017 at 12:18, Ivan Kalvachev wrote: > This patch is ready for review and inclusion. > > > >+%macro emu_blendvps 3 ; dst/src_a, src_b, mask >+%macro lea_pic_base 2; reg, const_label Capitalize macro names. >+ %error sse41 blendvps uses xmm0 as default 3d operand, you used %3 Rem

[FFmpeg-devel] [PATCH]v5 Opus Pyramid Vector Quantization Search in x86 SIMD asm

2017-07-22 Thread Ivan Kalvachev
This patch is ready for review and inclusion. Explanation of what it does and how it works could be found in the previous WIP threads: [v1] http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/212146.html [v2] http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/212816.html [v3] http://ffmpeg.org/pipe