Re: [FFmpeg-devel] [PATCH]lavf/mpegtsenc: Set min PID for data pkt to 0x0010

2016-09-28 Thread Carl Eugen Hoyos
2016-09-27 9:15 GMT+02:00 Carl Eugen Hoyos : > 2016-09-27 5:42 GMT+02:00 Andrey Turkin : >> Nevermind, I didn't though this through. Default value is high enough to >> comply with all standards. > > I'll apply the patch if there are no objections. Patch applied. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavf/mpegtsenc: Set min PID for data pkt to 0x0010

2016-09-27 Thread Carl Eugen Hoyos
2016-09-27 5:42 GMT+02:00 Andrey Turkin : > Nevermind, I didn't though this through. Default value is high enough to > comply with all standards. I'll apply the patch if there are no objections. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH]lavf/mpegtsenc: Set min PID for data pkt to 0x0010

2016-09-26 Thread Andrey Turkin
Nevermind, I didn't though this through. Default value is high enough to comply with all standards. If someone really wants/needs to use 0x0010 as PMT/data pids then it should be permitted since it is permitted by 13818-1:2000. By the same logic upper limit should be set to 0x1FFE. Though it would

Re: [FFmpeg-devel] [PATCH]lavf/mpegtsenc: Set min PID for data pkt to 0x0010

2016-09-26 Thread Andrey Turkin
ISO 18318 reserves PIDs 0x00-0x0F DVB also reserves PIDs 0x10-0x1F ARIB also reserves PIDs 0x20-0x2F ATSC also reserves PID 0x1FFB So, if there is going to be change to permitted PIDs assignment anyway, I suggest to go with safest choice and use 0x0030-0x1FEF range 2016-09-27 4:41 GMT+03:00 Micha

Re: [FFmpeg-devel] [PATCH]lavf/mpegtsenc: Set min PID for data pkt to 0x0010

2016-09-26 Thread Michael Niedermayer
On Sat, Sep 24, 2016 at 12:06:07PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #1673. > ISO13818-1 indeed specifies in §2.4.3.3 that values > up to 0xF are reserved. > > Please comment, Carl Eugen > mpegtsenc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] [PATCH]lavf/mpegtsenc: Set min PID for data pkt to 0x0010

2016-09-24 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #1673. ISO13818-1 indeed specifies in §2.4.3.3 that values up to 0xF are reserved. Please comment, Carl Eugen From 06371416c00eaf73430d1bb7d841167356adbe23 Mon Sep 17 00:00:00 2001 From: Sylvain Laurent Date: Sat, 24 Sep 2016 12:01:34 +0200 Subject: [PATCH] lavf/