Re: [FFmpeg-devel] [PATCH]lavf/movenc: Do not write empty av1C boxes

2020-03-30 Thread James Almer
On 3/30/2020 7:44 PM, Carl Eugen Hoyos wrote: > Am Di., 31. März 2020 um 00:35 Uhr schrieb James Almer : >> >> On 3/30/2020 7:19 PM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch avoids writing an mp4 file that cannot be read by >>> FFmpeg (only be vlc) in some use cases. >>> >>> Please co

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Do not write empty av1C boxes

2020-03-30 Thread Carl Eugen Hoyos
Am Di., 31. März 2020 um 00:35 Uhr schrieb James Almer : > > On 3/30/2020 7:19 PM, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch avoids writing an mp4 file that cannot be read by > > FFmpeg (only be vlc) in some use cases. > > > > Please comment, Carl Eugen > > This enables writing non com

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Do not write empty av1C boxes

2020-03-30 Thread James Almer
On 3/30/2020 7:19 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch avoids writing an mp4 file that cannot be read by > FFmpeg (only be vlc) in some use cases. > > Please comment, Carl Eugen This enables writing non compliant files, so no. We should instead check the return value of mov_write

[FFmpeg-devel] [PATCH]lavf/movenc: Do not write empty av1C boxes

2020-03-30 Thread Carl Eugen Hoyos
Hi! Attached patch avoids writing an mp4 file that cannot be read by FFmpeg (only be vlc) in some use cases. Please comment, Carl Eugen From 42b5e30f3bf13620a41ed92181f7b0358873e764 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 31 Mar 2020 00:17:44 +0200 Subject: [PATCH] lavf/movenc