Michael Niedermayer niedermayer.cc> writes:
> feel free to push the variant you tested
Done, thank you!
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On Mon, Aug 17, 2015 at 07:59:56PM +, Carl Eugen Hoyos wrote:
> Michael Niedermayer niedermayer.cc> writes:
>
> > +ffio_ensure_seekback(pb, 8);
> > +buffer = avio_rb64(pb);
> > +atom.size -= 8;
> > +if ( (buffer & 0x) == MKBETAG('f','r'
Michael Niedermayer niedermayer.cc> writes:
> +ffio_ensure_seekback(pb, 8);
> +buffer = avio_rb64(pb);
> +atom.size -= 8;
> +if ( (buffer & 0x) == MKBETAG('f','r','m','a')
> +&& buffer >> 32 <= atom.size
> +&
On Wed, Aug 05, 2015 at 11:52:43PM +0200, Carl Eugen Hoyos wrote:
> On Wednesday 05 August 2015 02:39:38 pm Michael Niedermayer wrote:
> > On Mon, Aug 03, 2015 at 11:16:12PM +0200, Carl Eugen Hoyos wrote:
> > > Hi!
> > >
> > > Attached patch fixes ticket #4747 and should not introduce any
> > > the
On Wednesday 05 August 2015 02:39:38 pm Michael Niedermayer wrote:
> On Mon, Aug 03, 2015 at 11:16:12PM +0200, Carl Eugen Hoyos wrote:
> > Hi!
> >
> > Attached patch fixes ticket #4747 and should not introduce any
> > theoretical regressions.
> >
> > Please review, Carl Eugen
> >
> > mov.c | 22
On Mon, Aug 03, 2015 at 11:16:12PM +0200, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch fixes ticket #4747 and should not introduce any
> theoretical regressions.
>
> Please review, Carl Eugen
> mov.c | 22 ++
> 1 file changed, 22 insertions(+)
> ffe1a030382f6bc11a5a58a
Michael Niedermayer niedermayer.cc> writes:
> > But this should not be necessary if somebody
> > can confirm that it is ok to seek back x bytes
> > in a demuxer.
>
> it is safe if ffio_ensure_seekback() is used with
> appropriate arguments before these x bytes are read
> (or the stream is see
Carl Eugen Hoyos ag.or.at> writes:
> Attached patch fixes ticket #4747 for me, I don't know how to
> detect that the wave atom contains no frma / alac atom...
New patch sent that detects and skips the frma atom or
reads the extradata if no frma atom is present.
Carl Eugen
Hi!
Attached patch fixes ticket #4747 and should not introduce any
theoretical regressions.
Please review, Carl Eugendiff --git a/libavformat/mov.c b/libavformat/mov.c
index 154d2f8..f3cb71f 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -1435,6 +1435,28 @@ static int mov_read_wave(MO
On Mon, Aug 03, 2015 at 10:32:02AM +, Carl Eugen Hoyos wrote:
> Paul B Mahol gmail.com> writes:
>
> > > Attached patch fixes ticket #4747 for me,
>
> > > I don't know how to detect that the wave
> > > atom contains no frma / alac atom...
> >
> > And that is mentioned because?
>
> The fil
2015-08-03 21:53 GMT+09:00 wm4 :
> On Mon, 3 Aug 2015 10:32:02 + (UTC)
> Carl Eugen Hoyos wrote:
>
> > Paul B Mahol gmail.com> writes:
> >
> > > > Attached patch fixes ticket #4747 for me,
> >
> > > > I don't know how to detect that the wave
> > > > atom contains no frma / alac atom...
> > >
On Mon, 3 Aug 2015 10:32:02 + (UTC)
Carl Eugen Hoyos wrote:
> Paul B Mahol gmail.com> writes:
>
> > > Attached patch fixes ticket #4747 for me,
>
> > > I don't know how to detect that the wave
> > > atom contains no frma / alac atom...
> >
> > And that is mentioned because?
>
> The fil
Paul B Mahol gmail.com> writes:
> > Attached patch fixes ticket #4747 for me,
> > I don't know how to detect that the wave
> > atom contains no frma / alac atom...
>
> And that is mentioned because?
The file from ticket #4747 does not contain an
alac atom which is required for alac decoding
On 8/1/15, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch fixes ticket #4747 for me, I don't know how to
> detect that the wave atom contains no frma / alac atom...
And that is mentioned because?
> Please comment, Carl Eugen
___
ffmpeg-devel mailing
Hi!
Attached patch fixes ticket #4747 for me, I don't know how to
detect that the wave atom contains no frma / alac atom...
Please comment, Carl Eugendiff --git a/libavformat/mov.c b/libavformat/mov.c
index fdba34c..dd48957 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -1434,6 +1434,
15 matches
Mail list logo
