On 23/11/2017 20:02, John Stebbins wrote:
[...] It's not practical to
know the duration of the previous subtitle before writing it because you can't
know it till you have seen this empty
PGS. Once you've seen the empty PGS, it is often too late to properly
interleave the previous PGS in the ou
On 11/23/2017 03:04 AM, Jerome Martinez wrote:
> On 12/11/2017 03:12, Carl Eugen Hoyos wrote:
>> The matroska spec says blockduration == 0 means the frame is not a
>> keyframe. Since all subtitles are "keyframes", 0 blockduration should
>> not be written.
> As I understand from discussion on CELLA
On 12/11/2017 03:12, Carl Eugen Hoyos wrote:
The matroska spec says blockduration == 0 means the frame is not a
keyframe. Since all subtitles are "keyframes", 0 blockduration should
not be written.
As I understand from discussion on CELLAR mailing-list:
- if is not expected to have a frame wit
2017-11-16 9:07 GMT+01:00 Jerome Martinez :
> On 12/11/2017 03:12, Carl Eugen Hoyos wrote:
>>
>> The matroska spec says blockduration == 0 means the frame is not a
>> keyframe. Since all subtitles are "keyframes", 0 blockduration should
>> not be written.
>
>
> The issue is in the specifications:
On 12/11/2017 03:12, Carl Eugen Hoyos wrote:
The matroska spec says blockduration == 0 means the frame is not a
keyframe. Since all subtitles are "keyframes", 0 blockduration should
not be written.
The issue is in the specifications:
https://github.com/Matroska-Org/matroska-specification/pull/
On 11/14/2017 02:18 PM, Carl Eugen Hoyos wrote:
> 2017-11-14 19:02 GMT+01:00 Jerome Martinez :
>> On 12/11/2017 03:12, Carl Eugen Hoyos wrote:
>>> -put_ebml_uint(pb, MATROSKA_ID_BLOCKDURATION, duration);
>>> +if (duration > 0)
>>> +put_ebml_uint(pb, MATROSKA
2017-11-14 19:02 GMT+01:00 Jerome Martinez :
> On 12/11/2017 03:12, Carl Eugen Hoyos wrote:
>>
>> -put_ebml_uint(pb, MATROSKA_ID_BLOCKDURATION, duration);
>> +if (duration > 0)
>> +put_ebml_uint(pb, MATROSKA_ID_BLOCKDURATION, duration);
>
>
> In that case, th
On 12/11/2017 03:12, Carl Eugen Hoyos wrote:
-put_ebml_uint(pb, MATROSKA_ID_BLOCKDURATION, duration);
+if (duration > 0)
+put_ebml_uint(pb, MATROSKA_ID_BLOCKDURATION, duration);
In that case, the duration of the block is DefaultDuration (if it
exists), c
Hi!
Attached patch by John Stebbins fixes a warning with mkvalidator here.
Please comment, Carl Eugen
From dab79ea5cd01187567b1761aaf1c329926483786 Wed Oct 29 00:00:00 2014
From: John Stebbins
Date: Wed, 29 Oct 2014 10:54:44 -0700
Subject: [PATCH] lavf/matroskaenc: Fix writing zero duration subt
