Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not allow -reserve_index_space 1

2018-02-12 Thread Carl Eugen Hoyos
2018-02-11 20:57 GMT+01:00 Nicolas George : > Carl Eugen Hoyos (2018-02-11): >> 2018-02-11 20:23 GMT+01:00 Nicolas George : >> > Carl Eugen Hoyos (2018-02-11): >> >> Attached patch fixes an assertion failure with the following command line: >> >> $ ffmpeg -f lavfi -i testsrc -reserve_index_space 1

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not allow -reserve_index_space 1

2018-02-11 Thread Nicolas George
Carl Eugen Hoyos (2018-02-11): > 2018-02-11 20:23 GMT+01:00 Nicolas George : > > Carl Eugen Hoyos (2018-02-11): > >> Attached patch fixes an assertion failure with the following command line: > >> $ ffmpeg -f lavfi -i testsrc -reserve_index_space 1 out.mkv > > > Reading the code, it is pretty obvi

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not allow -reserve_index_space 1

2018-02-11 Thread Carl Eugen Hoyos
2018-02-11 20:23 GMT+01:00 Nicolas George : > Carl Eugen Hoyos (2018-02-11): >> Attached patch fixes an assertion failure with the following command line: >> $ ffmpeg -f lavfi -i testsrc -reserve_index_space 1 out.mkv > Reading the code, it is pretty obvious that 0 is a valid value and > forbiddin

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not allow -reserve_index_space 1

2018-02-11 Thread Nicolas George
Carl Eugen Hoyos (2018-02-11): > Attached patch fixes an assertion failure with the following command line: > $ ffmpeg -f lavfi -i testsrc -reserve_index_space 1 out.mkv > > Please comment, Carl Eugen Reading the code, it is pretty obvious that 0 is a valid value and forbidding it would be bad.

[FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not allow -reserve_index_space 1

2018-02-11 Thread Carl Eugen Hoyos
Hi! Attached patch fixes an assertion failure with the following command line: $ ffmpeg -f lavfi -i testsrc -reserve_index_space 1 out.mkv Please comment, Carl Eugen From 4566d5f90f24bf2373175a8aad84c82be6b1a9eb Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 11 Feb 2018 20:16:02 +010