Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-07 Thread Carl Eugen Hoyos
2017-03-03 0:31 GMT+01:00 Michael Niedermayer : > On Wed, Mar 01, 2017 at 11:43:15PM +0100, Carl Eugen Hoyos wrote: >> Subject: [PATCH] lavf/matroska: Support codec ID V_FFV1 for demuxing. >> >> Fixes ticket #6206. >> --- >> libavformat/matroska.c|1 + >> libavformat/matroskaenc.c |2

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 11:43:15PM +0100, Carl Eugen Hoyos wrote: > 2017-03-01 13:07 GMT+01:00 Michael Niedermayer : > > On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: > >> 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : > >> > On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Michael Niedermayer
On Thu, Mar 02, 2017 at 04:43:27PM -0500, Dave Rice wrote: > > > On Mar 2, 2017, at 9:59 AM, James Almer wrote: > > > > On 3/2/2017 11:47 AM, Tobias Rapp wrote: > >> On 02.03.2017 15:22, James Almer wrote: > >>> On 3/2/2017 6:28 AM, Nicolas George wrote: > Le primidi 11 ventôse, an CCXXV, J

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Dave Rice
> On Mar 2, 2017, at 9:59 AM, James Almer wrote: > > On 3/2/2017 11:47 AM, Tobias Rapp wrote: >> On 02.03.2017 15:22, James Almer wrote: >>> On 3/2/2017 6:28 AM, Nicolas George wrote: Le primidi 11 ventôse, an CCXXV, James Almer a écrit : > Ah, i see there's generic code to read and wri

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Carl Eugen Hoyos
2017-03-01 23:43 GMT+01:00 Carl Eugen Hoyos : > 2017-03-01 13:07 GMT+01:00 Michael Niedermayer : >> On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: >>> 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : >>> > On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: >>> >> Hi

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread James Almer
On 3/2/2017 11:47 AM, Tobias Rapp wrote: > On 02.03.2017 15:22, James Almer wrote: >> On 3/2/2017 6:28 AM, Nicolas George wrote: >>> Le primidi 11 ventôse, an CCXXV, James Almer a écrit : Ah, i see there's generic code to read and write CodecPrivate elements to and from raw extradata for

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread James Almer
On 3/2/2017 5:44 AM, Carl Eugen Hoyos wrote: > 2017-03-02 0:26 GMT+01:00 James Almer : >> On 3/1/2017 7:18 PM, Carl Eugen Hoyos wrote: > This doesn't consider the CodecPrivate contents for FFV1 v3 and above. It's only valid for v1 and v2. >>> >>> Is this comment meant for the muxer or th

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Tobias Rapp
On 02.03.2017 15:22, James Almer wrote: On 3/2/2017 6:28 AM, Nicolas George wrote: Le primidi 11 ventôse, an CCXXV, James Almer a écrit : Ah, i see there's generic code to read and write CodecPrivate elements to and from raw extradata for native codecids where no special handling is required.

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread James Almer
On 3/2/2017 6:28 AM, Nicolas George wrote: > Le primidi 11 ventôse, an CCXXV, James Almer a écrit : >> Ah, i see there's generic code to read and write CodecPrivate elements >> to and from raw extradata for native codecids where no special handling >> is required. >> >> In any case, the spec says >

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Peter B.
On 03/01/2017 03:00 PM, Jerome Martinez wrote: > My suggestion: > - support by the demuxer > - for the muxer, support only if a specific explicit option is set, > default stays AVI compatibility layer (no break in playback by old > players). This sounds like a very practical approach to me: New fi

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Nicolas George
Le primidi 11 ventôse, an CCXXV, James Almer a écrit : > Ah, i see there's generic code to read and write CodecPrivate elements > to and from raw extradata for native codecids where no special handling > is required. > > In any case, the spec says > > "For FFV1 versions 2 or less, Private Data SH

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Carl Eugen Hoyos
2017-03-02 0:26 GMT+01:00 James Almer : > On 3/1/2017 7:18 PM, Carl Eugen Hoyos wrote: >>> This doesn't consider the CodecPrivate contents for FFV1 v3 >>> and above. It's only valid for v1 and v2. >> >> Is this comment meant for the muxer or the demuxer part? >> >> How can I reproduce the issue yo

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread James Almer
On 3/1/2017 7:18 PM, Carl Eugen Hoyos wrote: > 2017-03-01 17:56 GMT+01:00 James Almer : >> On 2/28/2017 4:45 PM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch fixes ticket #6206 here. >>> >>> Please comment, Carl Eugen >> >> This doesn't consider the CodecPrivate contents for FFV1 v3 >> an

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Carl Eugen Hoyos
2017-03-01 13:07 GMT+01:00 Michael Niedermayer : > On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: >> 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : >> > On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: >> >> Hi! >> >> >> >> Attached patch fixes ticket #6206 here

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Carl Eugen Hoyos
2017-03-01 17:56 GMT+01:00 James Almer : > On 2/28/2017 4:45 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #6206 here. >> >> Please comment, Carl Eugen > > This doesn't consider the CodecPrivate contents for FFV1 v3 > and above. It's only valid for v1 and v2. Is this comment

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread James Almer
On 2/28/2017 4:45 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #6206 here. > > Please comment, Carl Eugen This doesn't consider the CodecPrivate contents for FFV1 v3 and above. It's only valid for v1 and v2. > > > 0001-lavf-matroska-Support-new-codec-id-V_FFV1-for-FFV1.pa

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Jerome Martinez
Le 01/03/2017 à 15:51, wm4 a écrit : On Wed, 1 Mar 2017 15:00:27 +0100 Jerome Martinez wrote: [...] then in 12 (or 24, or 36 months), the time that new FFmpeg versions propagate everywhere (we also open tickets for other demuxers in order to get the support of such files), the default is chang

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread wm4
On Wed, 1 Mar 2017 15:00:27 +0100 Jerome Martinez wrote: > Le 01/03/2017 à 09:43, Carl Eugen Hoyos a écrit : > > 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : > >> On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: > >>> Hi! > >>> > >>> Attached patch fixes ticket #6206 here.

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Jerome Martinez
Le 01/03/2017 à 09:43, Carl Eugen Hoyos a écrit : 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: Hi! Attached patch fixes ticket #6206 here. Please comment, Carl Eugen previous ffmpeg versions dont play these files What do y

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread wm4
On Wed, 1 Mar 2017 14:26:34 +0100 Michael Niedermayer wrote: > On Wed, Mar 01, 2017 at 01:36:26PM +0100, wm4 wrote: > > On Wed, 1 Mar 2017 13:07:12 +0100 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: > > > > 2017-03-01 4:40 GMT+01

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 01:36:26PM +0100, wm4 wrote: > On Wed, 1 Mar 2017 13:07:12 +0100 > Michael Niedermayer wrote: > > > On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: > > > 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : > > > > On Tue, Feb 28, 2017 at 08:45:44PM +0100, C

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread wm4
On Wed, 1 Mar 2017 13:07:12 +0100 Michael Niedermayer wrote: > On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: > > 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : > > > On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: > > >> Hi! > > >> > > >> Attached patch

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Reto Kromer
Michael Niedermayer wrote: >> FFV1 didn't have any mapping in matroska before this, so >> what exactly is there to support? > >mkv supports all avi identifers, i assume that is what was >used before > >> Also, format support is technically a feature, so back- >> porting seems ill-advised. > >I th

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 01:18:09PM +0100, Hendrik Leppkes wrote: > On Wed, Mar 1, 2017 at 1:07 PM, Michael Niedermayer > wrote: > > On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: > >> 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : > >> > On Tue, Feb 28, 2017 at 08:45:44PM +0100

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Carl Eugen Hoyos
2017-03-01 13:18 GMT+01:00 Hendrik Leppkes : > FFV1 didn't have any mapping in matroska before this I believe it is safe to say that many people used ffv1 in mkv and they would be surprised if their new files suddenly didn't play in vlc. Carl Eugen ___

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Hendrik Leppkes
On Wed, Mar 1, 2017 at 1:07 PM, Michael Niedermayer wrote: > On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: >> 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : >> > On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: >> >> Hi! >> >> >> >> Attached patch fixes ticket

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: > 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : > > On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> Attached patch fixes ticket #6206 here. > >> > >> Please comment, Carl Eugen > > > > previous

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-01 Thread Carl Eugen Hoyos
2017-03-01 4:40 GMT+01:00 Michael Niedermayer : > On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #6206 here. >> >> Please comment, Carl Eugen > > previous ffmpeg versions dont play these files What do you suggest? Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-02-28 Thread Michael Niedermayer
On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #6206 here. > > Please comment, Carl Eugen previous ffmpeg versions dont play these files [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State e

[FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-02-28 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #6206 here. Please comment, Carl Eugen From 10caa3898fa76f5a76dce7e3795a7a0d475870c1 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 28 Feb 2017 20:36:12 +0100 Subject: [PATCH] lavf/matroska: Support new codec id V_FFV1 for FFV1. Fixes ticket #6206. --