Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Paul B Mahol
On Sun, Feb 21, 2021 at 2:23 PM Carl Eugen Hoyos wrote: > Am So., 21. Feb. 2021 um 14:12 Uhr schrieb Paul B Mahol >: > > > > On Sun, Feb 21, 2021 at 2:10 PM Carl Eugen Hoyos > wrote: > > > > > Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol < > one...@gmail.com > > > >: > > > > > > > >

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Am So., 21. Feb. 2021 um 14:12 Uhr schrieb Paul B Mahol : > > On Sun, Feb 21, 2021 at 2:10 PM Carl Eugen Hoyos wrote: > > > Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol > >: > > > > > > Because there is not point in it. > > > Number of frames should always be probed. > > > > It is neit

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Paul B Mahol
On Sun, Feb 21, 2021 at 2:10 PM Carl Eugen Hoyos wrote: > Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol >: > > > > Because there is not point in it. > > Number of frames should always be probed. > > It is neither necessary nor useful to probe it. > Both is immediately obvious: > You al

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol : > > Because there is not point in it. > Number of frames should always be probed. It is neither necessary nor useful to probe it. Both is immediately obvious: You already check 48 bits, ruling out one possible value for 32bit does not impro

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Paul B Mahol
Because there is not point in it. Number of frames should always be probed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Am So., 21. Feb. 2021 um 11:39 Uhr schrieb Paul B Mahol : > > This patch is not good. Could you elaborate? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abov

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Paul B Mahol
This patch is not good. Probe function should not be changed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Hi! The Simbiosis IMX probe function looks strict enough, do not check for a field that does not cause decoding to fail. Please comment, Carl Eugen From 62ce4e42c1dae6696007e22cd13a8e43eabbc38d Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 21 Feb 2021 10:31:16 +0100 Subject: [PATCH]